Skip to content

Commit 6e8d2b2

Browse files
authored
Merge pull request #1936 from lachieh/socket-io-upgrade
Upgrade to latest version of socket.io due to security vulnerability
2 parents a7c14c8 + e909447 commit 6e8d2b2

File tree

9 files changed

+12835
-7037
lines changed

9 files changed

+12835
-7037
lines changed

packages/browser-sync-client/lib/browser.utils.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export function setScroll(pos) {
132132
* Hard reload
133133
*/
134134
export function reloadBrowser() {
135-
getWindow().location.reload(true);
135+
getWindow().location.reload();
136136
}
137137

138138
/**
@@ -151,6 +151,8 @@ export function forEach(coll, fn) {
151151
* @returns {boolean}
152152
*/
153153
export function isOldIe() {
154+
// @ts-ignore - Only IE < 11 has .attachEvent property
155+
// https://docs.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/platform-apis/aa703974(v=vs.85)
154156
return typeof getWindow().attachEvent !== "undefined";
155157
}
156158

packages/browser-sync-client/lib/effects/browser-reload.effect.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ export function preBrowserReload() {
1515
export function browserReloadEffect(xs: Observable<any>, inputs: Inputs) {
1616
return xs.pipe(
1717
withLatestFrom(inputs.window$),
18-
tap(([, window]) => window.location.reload(true))
18+
tap(([, window]) => window.location.reload())
1919
);
2020
}

0 commit comments

Comments
 (0)