Skip to content

Commit 56b4a82

Browse files
committed
test(@angular-devkit/build-angular): re-enable font-awesome test
1 parent f0f0a03 commit 56b4a82

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

packages/angular_devkit/build_angular/test/browser/assets_spec_large.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,5 +63,9 @@ describe('Browser Builder assets', () => {
6363
};
6464

6565
runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, done, done.fail);
66+
67+
// The node_modules folder must be deleted, otherwise code that tries to find the
68+
// node_modules folder will hit this one and can fail.
69+
host.scopedSync().delete(normalize('./node_modules'));
6670
}, Timeout.Basic);
6771
});

packages/angular_devkit/build_angular/test/browser/styles_spec_large.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,7 @@ describe('Browser Builder styles', () => {
332332
).subscribe(undefined, done.fail, done);
333333
}, Timeout.Basic);
334334

335-
// Disables a test that relies on node_modules.
336-
xit(`supports font-awesome imports`, (done) => {
335+
it(`supports font-awesome imports`, (done) => {
337336
host.writeMultipleFiles({
338337
'src/styles.scss': `
339338
$fa-font-path: "~font-awesome/fonts";
@@ -345,10 +344,6 @@ describe('Browser Builder styles', () => {
345344

346345
runTargetSpec(host, browserTargetSpec, overrides).pipe(
347346
tap((buildEvent) => expect(buildEvent.success).toBe(true)),
348-
// TODO: find a way to check logger/output for warnings.
349-
// if (stdout.match(/postcss-url: \.+: Can't read file '\.+', ignoring/)) {
350-
// throw new Error('Expected no postcss-url file read warnings.');
351-
// }
352347
).subscribe(undefined, done.fail, done);
353348
}, 30000);
354349

0 commit comments

Comments
 (0)