Clean up digital code after update

Signed-off-by: Frederic.Pillon <[email protected]>

Author: fpistm

cores/arduino/stm32/digital_io.c

@@ -1,9 +1,6 @@
 /**
   ******************************************************************************
   * @file    digital_io.c
-  * @author  WI6LABS
-  * @version V1.0.0
-  * @date    01-August-2016
   * @brief   Provide an interface to configure hw ios
   *
   ******************************************************************************
@@ -39,7 +36,7 @@
 #include "PinAF_STM32F1.h"
 
 #ifdef __cplusplus
- extern "C" {
+extern "C" {
 #endif
 
 /**

cores/arduino/stm32/digital_io.h

@@ -1,9 +1,6 @@
 /**
   ******************************************************************************
   * @file    digital_io.h
-  * @author  WI6LABS
-  * @version V1.0.0
-  * @date    01-August-2016
   * @brief   Header for digital_io module
   ******************************************************************************
   * @attention
@@ -45,12 +42,9 @@
 #include "stm32yyxx_ll_gpio.h"
 
 #ifdef __cplusplus
- extern "C" {
+extern "C" {
 #endif
 
-/* Exported types ------------------------------------------------------------*/
-/* Exported constants --------------------------------------------------------*/
-/* Exported macro ------------------------------------------------------------*/
 /* Exported functions ------------------------------------------------------- */
 void digital_io_init(PinName pin, uint32_t mode, uint32_t pull);
 
@@ -63,15 +57,15 @@ void digital_io_init(PinName pin, uint32_t mode, uint32_t pull);
   */
 static inline void digital_io_write(GPIO_TypeDef *port, uint32_t pin, uint32_t val)
 {
-  if(val) {
+  if (val) {
     LL_GPIO_SetOutputPin(port, pin);
   } else {
     LL_GPIO_ResetOutputPin(port, pin);
   }
 }
 
 /**
-  * @brief  This function set a value to an IO
+  * @brief  This function read the value of an IO
   * @param  port : one of the gpio port
   * @param  pin : one of the gpio pin
   * @retval The pin state (LOW or HIGH)
@@ -98,9 +92,9 @@ static inline void digital_io_toggle(GPIO_TypeDef *port, uint32_t pin)
   * @param  val : 0 to set to low, any other value to set to high
   * @retval None
   */
-static inline void digitalWriteFast( PinName pn, uint32_t ulVal )
+static inline void digitalWriteFast(PinName pn, uint32_t ulVal)
 {
-  if(pn != NC) {
+  if (pn != NC) {
     digital_io_write(get_GPIO_Port(STM_PORT(pn)), STM_GPIO_PIN(pn), ulVal);
   }
 }
@@ -110,13 +104,13 @@ static inline void digitalWriteFast( PinName pn, uint32_t ulVal )
   * @param  pn : Pin name
   * @retval The pin state (LOW or HIGH)
   */
-static inline int digitalReadFast( PinName pn )
+static inline int digitalReadFast(PinName pn)
 {
   uint8_t level = 0;
-  if(pn != NC) {
+  if (pn != NC) {
     level = digital_io_read(get_GPIO_Port(STM_PORT(pn)), STM_GPIO_PIN(pn));
   }
-  return (level)? HIGH : LOW;
+  return (level) ? HIGH : LOW;
 }
 
 /**
@@ -127,7 +121,7 @@ static inline int digitalReadFast( PinName pn )
   */
 static inline void digitalToggleFast(PinName pn)
 {
-  if(pn != NC) {
+  if (pn != NC) {
     digital_io_toggle(get_GPIO_Port(STM_PORT(pn)), STM_GPIO_PIN(pn));
   }
 }

cores/arduino/wiring_digital.c

@@ -20,7 +20,7 @@
 #include "PinConfigured.h"
 
 #ifdef __cplusplus
- extern "C" {
+extern "C" {
 #endif
 
 
@@ -29,56 +29,55 @@ uint32_t g_digPinConfigured[MAX_NB_PORT] = {0};
 extern uint32_t g_anOutputPinConfigured[MAX_NB_PORT];
 
 
-void pinMode( uint32_t ulPin, uint32_t ulMode )
+void pinMode(uint32_t ulPin, uint32_t ulMode)
 {
   PinName p = digitalPinToPinName(ulPin);
 
-  if(p != NC) {
+  if (p != NC) {
     // If the pin that support PWM or DAC output, we need to turn it off
-    if(is_pin_configured(p, g_anOutputPinConfigured)) {
+    if (is_pin_configured(p, g_anOutputPinConfigured)) {
 #ifdef HAL_DAC_MODULE_ENABLED
-      if(pin_in_pinmap(p, PinMap_DAC)) {
+      if (pin_in_pinmap(p, PinMap_DAC)) {
         dac_stop(p);
       } else
 #endif //HAL_DAC_MODULE_ENABLED
-      if(pin_in_pinmap(p, PinMap_PWM)) {
-        pwm_stop(p);
-      }
+        if (pin_in_pinmap(p, PinMap_PWM)) {
+          pwm_stop(p);
+        }
       reset_pin_configured(p, g_anOutputPinConfigured);
     }
 
-    switch ( ulMode )
-    {
+    switch (ulMode) {
       case INPUT:
         digital_io_init(p, GPIO_MODE_INPUT, GPIO_NOPULL);
-      break;
+        break;
       case INPUT_PULLUP:
         digital_io_init(p, GPIO_MODE_INPUT, GPIO_PULLUP);
-      break;
+        break;
       case INPUT_PULLDOWN:
         digital_io_init(p, GPIO_MODE_INPUT, GPIO_PULLDOWN);
-      break;
+        break;
       case OUTPUT:
         digital_io_init(p, GPIO_MODE_OUTPUT_PP, GPIO_NOPULL);
-      break;
+        break;
       default:
-      break;
+        break;
     }
     set_pin_configured(p, g_digPinConfigured);
   }
 }
 
-void digitalWrite( uint32_t ulPin, uint32_t ulVal )
+void digitalWrite(uint32_t ulPin, uint32_t ulVal)
 {
   digitalWriteFast(digitalPinToPinName(ulPin), ulVal);
 }
 
-int digitalRead( uint32_t ulPin )
+int digitalRead(uint32_t ulPin)
 {
   return digitalReadFast(digitalPinToPinName(ulPin));
 }
 
-void digitalToggle( uint32_t ulPin )
+void digitalToggle(uint32_t ulPin)
 {
   digitalToggleFast(digitalPinToPinName(ulPin));
 }

cores/arduino/wiring_digital.h

@@ -20,38 +20,27 @@
 #define _WIRING_DIGITAL_
 
 #ifdef __cplusplus
- extern "C" {
+extern "C" {
 #endif
 
 /**
- * \brief Configures the specified pin to behave either as an input or an output. See the description of digital pins for details.
+ * \brief Configures the specified pin to behave either as an input or an output.
  *
- * \param ulPin The number of the pin whose mode you wish to set
- * \param ulMode Either INPUT or OUTPUT
+ * \param dwPin The number of the pin whose mode you wish to set
+ * \param dwMode Either INPUT, INPUT_PULLUP, INPUT_PULLDOWN or OUTPUT
  */
-extern void pinMode( uint32_t dwPin, uint32_t dwMode ) ;
+extern void pinMode(uint32_t dwPin, uint32_t dwMode) ;
 
 /**
  * \brief Write a HIGH or a LOW value to a digital pin.
  *
  * If the pin has been configured as an OUTPUT with pinMode(), its voltage will be set to the
- * corresponding value: 5V (or 3.3V on 3.3V boards) for HIGH, 0V (ground) for LOW.
- *
- * If the pin is configured as an INPUT, writing a HIGH value with digitalWrite() will enable an internal
- * 20K pullup resistor (see the tutorial on digital pins). Writing LOW will disable the pullup. The pullup
- * resistor is enough to light an LED dimly, so if LEDs appear to work, but very dimly, this is a likely
- * cause. The remedy is to set the pin to an output with the pinMode() function.
- *
- * \note Digital pin PIN_LED is harder to use as a digital input than the other digital pins because it has an LED
- * and resistor attached to it that's soldered to the board on most boards. If you enable its internal 20k pull-up
- * resistor, it will hang at around 1.7 V instead of the expected 5V because the onboard LED and series resistor
- * pull the voltage level down, meaning it always returns LOW. If you must use pin PIN_LED as a digital input, use an
- * external pull down resistor.
+ * corresponding value: 3.3V for HIGH, 0V (ground) for LOW.
  *
  * \param dwPin the pin number
  * \param dwVal HIGH or LOW
  */
-extern void digitalWrite( uint32_t dwPin, uint32_t dwVal ) ;
+extern void digitalWrite(uint32_t dwPin, uint32_t dwVal) ;
 
 /**
  * \brief Reads the value from a specified digital pin, either HIGH or LOW.
@@ -60,14 +49,14 @@ extern void digitalWrite( uint32_t dwPin, uint32_t dwVal ) ;
  *
  * \return HIGH or LOW
  */
-extern int digitalRead( uint32_t ulPin ) ;
+extern int digitalRead(uint32_t ulPin) ;
 
 /**
  * \brief Toggle the value from a specified digital pin.
  *
  * \param ulPin The number of the digital pin you want to toggle (int)
  */
-extern void digitalToggle( uint32_t ulPin ) ;
+extern void digitalToggle(uint32_t ulPin) ;
 
 #ifdef __cplusplus
 }