fix(ngModel): treat synchronous validators as boolean always

Change synchronous validators to convert the return to boolean value.
Prevent unexpected behavior when returning `undefined`.

Closes angular#14734
BREAKING CHANGE: Previously, only a literal `false` return would resolve as the
synchronous validator failing. Now, all traditionally false JavaScript values
are treated as failing the validator, as one would naturally expect.

Specifically, the values `0` (the number zero), `null`, `NaN` and `''` (the
empty string) used to considered valid (passing) and they are now considered
invalid (failing). The value `undefined` was treated similarly to a pending
asynchronous validator, causing the validation to be pending. `undefined` is
also now considered invalid.

To migrate, make sure your synchronous validators are returning either a
literal `true` or a literal `false` value. For most code, we expect this to
already be the case. Only a very small subset of projects will be affected.

Namely, anyone using `undefined` or any falsy value as a return will now see
their validation failing, whereas previously falsy values other than `undefined`
would have been seen as passing and `undefined` would have been seen as pending.

Author: BobChao87

test/ng/directive/ngModelSpec.js

@@ -847,36 +847,36 @@ describe('ngModel', function() {
         expect(ctrl.$valid).toBe(true);
       });
 
-      it('should treat all responses as boolean for synchronous validators', function() {
-        var curry = function(v) {
-          return function() {
-            return v;
-          };
-        };
-
-        var tester = function(v, e) {
+      fit('should treat all responses as boolean for synchronous validators', function() {
+        // var curry = function(v) {
+        //   return function() {
+        //     return v;
+        //   };
+        // };
+
+        var expectValid = function(v, e) {
           ctrl.$modelValue = undefined;
-          ctrl.$validators.a = curry(v);
+          ctrl.$validators.a = valueFn(v);
 
           ctrl.$validate();
           expect(ctrl.$valid).toBe(e);
         };
 
         // False tests
-        tester(false, false);
-        tester(undefined, false);
-        tester(null, false);
-        tester(0, false);
-        tester(NaN, false);
-        tester('', false);
+        expectValid(false, false);
+        expectValid(undefined, false);
+        expectValid(null, false);
+        expectValid(0, false);
+        expectValid(NaN, false);
+        expectValid('', false);
 
         // True tests
-        tester(true, true);
-        tester(1, true);
-        tester('0', true);
-        tester('false', true);
-        tester([], true);
-        tester({}, true);
+        expectValid(true, true);
+        expectValid(1, true);
+        expectValid('0', true);
+        expectValid('false', true);
+        expectValid([], true);
+        expectValid({}, true);
       });