Skip to content

Commit beba2fa

Browse files
assignUserArgusLi
authored andcommitted
apacheGH-35060: [C#][CI] Update dotnet download link regex (apache#35061)
The download page changed and the existing regex was not correctly catching the link. This seems overall pretty brittle but it seems there is no better way to download the file directly. * Closes: apache#35060 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent bf0c8a0 commit beba2fa

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

dev/release/verify-release-candidate.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,8 +366,8 @@ install_csharp() {
366366
local dotnet_download_thank_you_url=https://dotnet.microsoft.com/download/thank-you/dotnet-sdk-${dotnet_version}-${dotnet_platform}-x64-binaries
367367
local dotnet_download_url=$( \
368368
curl -sL ${dotnet_download_thank_you_url} | \
369-
grep 'window\.open' | \
370-
grep -E -o '[^"]+' | \
369+
grep 'directLink' | \
370+
grep -E -o 'https://download[^"]+' | \
371371
sed -n 2p)
372372
mkdir -p ${csharp_bin}
373373
curl -sL ${dotnet_download_url} | \

0 commit comments

Comments
 (0)