Skip to content

Commit e1e9ca2

Browse files
committed
fix deprecation warning from pandas
the inplace version of pandas.fillna apparently shouldn't be used see pandas-dev/pandas#16529
1 parent 58538fb commit e1e9ca2

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/odm_sharing/private/rules.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,9 @@ def load(schema_path: str) -> Dict[RuleId, Rule]:
218218
filename = Path(schema_path).name
219219
ctx = SchemaCtx(filename)
220220
data = pd.read_csv(schema_path)
221-
data.fillna('', inplace=True) # replace NA values with empty string
221+
222+
# replace all different NA values with an empty string
223+
data = data.fillna('')
222224

223225
# XXX: loading is aborted on header errors since row-parsing depends on it
224226
validate_headers(ctx, data.columns.to_list())

0 commit comments

Comments
 (0)