Corrected use of const

Author: Bascy

libraries/BLE/src/BLEAddress.cpp

@@ -62,34 +62,34 @@ bool BLEAddress::equals(BLEAddress otherAddress) {
 	return memcmp(otherAddress.getNative(), m_address, ESP_BD_ADDR_LEN) == 0;
 } // equals
 
-bool BLEAddress::operator==(BLEAddress otherAddress) {
-  return equals(otherAddress);
+bool BLEAddress::operator==(const BLEAddress& otherAddress) const {
+	return memcmp(otherAddress.m_address, m_address, ESP_BD_ADDR_LEN) == 0;
 }
 
-bool BLEAddress::operator!=(BLEAddress otherAddress) {
-  return ! this == otherAddress;
+bool BLEAddress::operator!=(const BLEAddress& otherAddress) const {
+  return !(*this == otherAddress);
 }
 
-bool BLEAddress::operator<(BLEAddress otherAddress) {
-  return memcmp(otherAddress.getNative(), m_address, ESP_BD_ADDR_LEN) < 0;
+bool BLEAddress::operator<(const BLEAddress& otherAddress) const {
+  return memcmp(otherAddress.m_address, m_address, ESP_BD_ADDR_LEN) < 0;
 }
 
-bool BLEAddress::operator<=(BLEAddress otherAddress) {
-  return !this > otherAddress;
+bool BLEAddress::operator<=(const BLEAddress& otherAddress) const {
+  return !(*this > otherAddress);
 }
 
-bool BLEAddress::operator>=(BLEAddress otherAddress) {
-  return !this < otherAddress;
+bool BLEAddress::operator>=(const BLEAddress& otherAddress) const {
+  return !(*this < otherAddress);
 }
 
-bool BLEAddress::operator>(BLEAddress otherAddress) {
-  return memcmp(otherAddress.getNative(), m_address, ESP_BD_ADDR_LEN) > 0;
+bool BLEAddress::operator>(const BLEAddress& otherAddress) const {
+  return memcmp(otherAddress.m_address, m_address, ESP_BD_ADDR_LEN) > 0;
 }
 
 /**
  * @brief Return the native representation of the address.
  * @return The native representation of the address.
- */
+ */   
 esp_bd_addr_t *BLEAddress::getNative() {
 	return &m_address;
 } // getNative

libraries/BLE/src/BLEAddress.h

@@ -23,12 +23,12 @@ class BLEAddress {
 	BLEAddress(esp_bd_addr_t address);
 	BLEAddress(std::string stringAddress);
 	bool           equals(BLEAddress otherAddress);
-  bool           operator==(BLEAddress otherAddress);
-  bool           operator!=(BLEAddress otherAddress);
-  bool           operator<(BLEAddress otherAddress);
-  bool           operator<=(BLEAddress otherAddress);
-  bool           operator>(BLEAddress otherAddress);
-  bool           operator>=(BLEAddress otherAddress);
+  bool           operator==(const BLEAddress& otherAddress) const;
+  bool           operator!=(const BLEAddress& otherAddress) const;
+  bool           operator<(const BLEAddress& otherAddress) const;
+  bool           operator<=(const BLEAddress& otherAddress) const;
+  bool           operator>(const BLEAddress& otherAddress) const;
+  bool           operator>=(const BLEAddress& otherAddress) const;
 	esp_bd_addr_t* getNative();
 	std::string    toString();