feedback

Author: YunchuWang

.github/workflows/ci_consumption_workflow.yml

@@ -32,7 +32,7 @@ jobs:
           python-version: ${{ matrix.python-version }}
       - name: Install dependencies
         run: |
-          python -m pip install --upgrade pip==23.0
+          python -m pip install --upgrade pip
           python -m pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple -U azure-functions --pre
           python -m pip install -U -e .[dev]
           if [[ "${{ matrix.python-version }}" != "3.7" ]]; then

.github/workflows/ci_e2e_workflow.yml

@@ -58,7 +58,7 @@ jobs:
             done
           }
 
-          python -m pip install --upgrade pip==23.0
+          python -m pip install --upgrade pip
           python -m pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple -U azure-functions --pre
           python -m pip install -U -e .[dev]
           if [[ "${{ matrix.python-version }}" != "3.7" ]]; then

.github/workflows/ci_ut_workflow.yml

@@ -56,8 +56,7 @@ jobs:
           done
         }
 
-        python -m pip install --upgrade pip==23.0
-        python -m pip install pipdeptree
+        python -m pip install --upgrade pip
         python -m pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple -U azure-functions --pre
         python -m pip install -U -e .[dev] 
         if [[ "${{ matrix.python-version }}" != "3.7" ]]; then

azure_functions_worker/dispatcher.py

@@ -314,7 +314,7 @@ async def _handle__worker_init_request(self, request):
                 self._function_metadata_exception = ex
 
             try:
-                if HttpV2Registry.http_v2_enabled(self._functions):
+                if HttpV2Registry.http_v2_enabled():
                     capabilities[constants.HTTP_URI] = \
                         initialize_http_server(self._host)
             except Exception as ex:
@@ -689,7 +689,7 @@ async def _handle__function_environment_reload_request(self, request):
                 except Exception as ex:
                     self._function_metadata_exception = ex
 
-                if HttpV2Registry.http_v2_enabled(self._functions):
+                if HttpV2Registry.http_v2_enabled():
                     capabilities[constants.HTTP_URI] = \
                         initialize_http_server(self._host)
 

azure_functions_worker/http_v2.py

@@ -143,15 +143,16 @@ def _pop_http_request(self, invoc_id):
             context_ref.http_request = None
             return request
 
-        raise Exception(f"No http request found for invocation {invoc_id}")
+        raise ValueError(f"No http request found for invocation {invoc_id}")
 
     def _pop_http_response(self, invoc_id):
         context_ref = self._context_references.get(invoc_id)
         response = context_ref.http_response
         if response is not None:
             context_ref.http_response = None
             return response
-        raise Exception(f"No http response found for invocation {invoc_id}")
+
+        raise ValueError(f"No http response found for invocation {invoc_id}")
 
 
 def get_unused_tcp_port():
@@ -184,12 +185,12 @@ async def catch_all(request: request_type):  # type: ignore
         invoc_id = request.headers.get(X_MS_INVOCATION_ID)
         if invoc_id is None:
             raise ValueError(f"Header {X_MS_INVOCATION_ID} not found")
-        logger.info(f'Received HTTP request for invocation {invoc_id}')
+        logger.info('Received HTTP request for invocation %s', invoc_id)
         http_coordinator.set_http_request(invoc_id, request)
         http_resp = \
             await http_coordinator.await_http_response_async(invoc_id)
 
-        logger.info(f'Sending HTTP response for invocation {invoc_id}')
+        logger.info('Sending HTTP response for invocation %s', invoc_id)
         # if http_resp is an python exception, raise it
         if isinstance(http_resp, Exception):
             raise http_resp
@@ -203,7 +204,7 @@ async def catch_all(request: request_type):  # type: ignore
     loop.create_task(web_server_run_task)
 
     web_server_address = f"http://{host_addr}:{unused_port}"
-    logger.info(f'HTTP server starting on {web_server_address}')
+    logger.info('HTTP server starting on %s', web_server_address)
 
     return web_server_address
 
@@ -224,7 +225,7 @@ class HttpV2Registry:
     _http_v2_enabled_checked = False
 
     @classmethod
-    def http_v2_enabled(cls, functions=None, **kwargs):
+    def http_v2_enabled(cls, **kwargs):
         # Check if HTTP/2 enablement has already been checked
         if not cls._http_v2_enabled_checked:
             # If not checked yet, mark as checked