initial refactoring to config manager class

Author: Victoria Hall

azure_functions_worker/bindings/shared_memory_data_transfer/file_accessor_factory.py

@@ -5,7 +5,7 @@
 import sys
 
 from ...constants import FUNCTIONS_WORKER_SHARED_MEMORY_DATA_TRANSFER_ENABLED
-from ...utils.config_manager import is_envvar_true
+from ...utils.config_manager import config_manager
 from .file_accessor import DummyFileAccessor
 from .file_accessor_unix import FileAccessorUnix
 from .file_accessor_windows import FileAccessorWindows
@@ -18,7 +18,7 @@ class FileAccessorFactory:
     """
     @staticmethod
     def create_file_accessor():
-        if sys.platform == "darwin" and not is_envvar_true(
+        if sys.platform == "darwin" and not config_manager.is_envvar_true(
                 FUNCTIONS_WORKER_SHARED_MEMORY_DATA_TRANSFER_ENABLED):
             return DummyFileAccessor()
         elif os.name == 'nt':

azure_functions_worker/bindings/shared_memory_data_transfer/file_accessor_unix.py

@@ -9,7 +9,7 @@
 from azure_functions_worker import constants
 
 from ...logging import logger
-from ...utils.config_manager import get_app_setting
+from ...utils.config_manager import config_manager
 from .file_accessor import FileAccessor
 from .shared_memory_constants import SharedMemoryConstants as consts
 from .shared_memory_exception import SharedMemoryException
@@ -95,7 +95,7 @@ def _get_allowed_mem_map_dirs(self) -> List[str]:
         Otherwise, the default value will be used.
         """
         setting = constants.UNIX_SHARED_MEMORY_DIRECTORIES
-        allowed_mem_map_dirs_str = get_app_setting(setting)
+        allowed_mem_map_dirs_str = config_manager.get_app_setting(setting)
         if allowed_mem_map_dirs_str is None:
             allowed_mem_map_dirs = consts.UNIX_TEMP_DIRS
             logger.info(

azure_functions_worker/bindings/shared_memory_data_transfer/shared_memory_manager.py

@@ -6,7 +6,7 @@
 
 from ...constants import FUNCTIONS_WORKER_SHARED_MEMORY_DATA_TRANSFER_ENABLED
 from ...logging import logger
-from ...utils.config_manager import is_envvar_true
+from ...utils.config_manager import config_manager
 from ..datumdef import Datum
 from .file_accessor_factory import FileAccessorFactory
 from .shared_memory_constants import SharedMemoryConstants as consts
@@ -55,7 +55,7 @@ def is_enabled(self) -> bool:
         Whether supported types should be transferred between functions host and
         the worker using shared memory.
         """
-        return is_envvar_true(
+        return config_manager.is_envvar_true(
             FUNCTIONS_WORKER_SHARED_MEMORY_DATA_TRANSFER_ENABLED)
 
     def is_supported(self, datum: Datum) -> bool:

azure_functions_worker/dispatcher.py

@@ -61,8 +61,7 @@
 )
 from .utils.app_setting_manager import get_python_appsetting_state
 from .utils.common import validate_script_file_name
-from .utils.config_manager import (clear_config, read_config,
-                                   is_envvar_true, get_app_setting)
+from .utils.config_manager import config_manager
 from .utils.dependency import DependencyManager
 from .utils.tracing import marshall_exception_trace
 from .utils.wrappers import disable_feature_by
@@ -209,7 +208,7 @@ async def dispatch_forever(self):  # sourcery skip: swap-if-expression
 
             log_level = (
                 logging.INFO
-                if not is_envvar_true(PYTHON_ENABLE_DEBUG_LOGGING)
+                if not config_manager.is_envvar_true(PYTHON_ENABLE_DEBUG_LOGGING)
                 else logging.DEBUG
             )
 
@@ -336,10 +335,10 @@ def initialize_azure_monitor(self):
                 # Connection string can be explicitly specified in Appsetting
                 # If not set, defaults to env var
                 # APPLICATIONINSIGHTS_CONNECTION_STRING
-                connection_string=get_app_setting(
+                connection_string=config_manager.get_app_setting(
                     setting=APPLICATIONINSIGHTS_CONNECTION_STRING
                 ),
-                logger_name=get_app_setting(
+                logger_name=config_manager.get_app_setting(
                     setting=PYTHON_AZURE_MONITOR_LOGGER_NAME,
                     default_value=PYTHON_AZURE_MONITOR_LOGGER_NAME_DEFAULT,
                 ),
@@ -376,7 +375,7 @@ async def _handle__worker_init_request(self, request):
         self._sync_call_tp = self._create_sync_call_tp(
             self._get_sync_tp_max_workers()
         )
-        read_config(
+        config_manager.read_config(
             os.path.join(worker_init_request.function_app_directory, "az-config.json")
         )
         logger.info(
@@ -406,7 +405,7 @@ async def _handle__worker_init_request(self, request):
             constants.RPC_HTTP_TRIGGER_METADATA_REMOVED: _TRUE,
             constants.SHARED_MEMORY_DATA_TRANSFER: _TRUE,
         }
-        if get_app_setting(
+        if config_manager.get_app_setting(
             setting=PYTHON_ENABLE_OPENTELEMETRY,
             default_value=PYTHON_ENABLE_OPENTELEMETRY_DEFAULT,
         ):
@@ -425,7 +424,7 @@ async def _handle__worker_init_request(self, request):
         # dictionary which will be later used in the invocation request
         bindings.load_binding_registry()
 
-        if is_envvar_true(PYTHON_ENABLE_INIT_INDEXING):
+        if config_manager.is_envvar_true(PYTHON_ENABLE_INIT_INDEXING):
             try:
                 self.load_function_metadata(
                     worker_init_request.function_app_directory,
@@ -466,7 +465,7 @@ def load_function_metadata(self, function_app_directory, caller_info):
         directory and save the results in function_metadata_result or
         function_metadata_exception in case of an exception.
         """
-        script_file_name = get_app_setting(
+        script_file_name = config_manager.get_app_setting(
             setting=PYTHON_SCRIPT_FILE_NAME,
             default_value=f"{PYTHON_SCRIPT_FILE_NAME_DEFAULT}",
         )
@@ -494,7 +493,7 @@ async def _handle__functions_metadata_request(self, request):
         metadata_request = request.functions_metadata_request
         function_app_directory = metadata_request.function_app_directory
 
-        script_file_name = get_app_setting(
+        script_file_name = config_manager.get_app_setting(
             setting=PYTHON_SCRIPT_FILE_NAME,
             default_value=f"{PYTHON_SCRIPT_FILE_NAME_DEFAULT}",
         )
@@ -506,7 +505,7 @@ async def _handle__functions_metadata_request(self, request):
             function_path,
         )
 
-        if not is_envvar_true(PYTHON_ENABLE_INIT_INDEXING):
+        if not config_manager.is_envvar_true(PYTHON_ENABLE_INIT_INDEXING):
             try:
                 self.load_function_metadata(
                     function_app_directory, caller_info="functions_metadata_request"
@@ -819,11 +818,11 @@ async def _handle__function_environment_reload_request(self, request):
 
             # Reload environment variables
             os.environ.clear()
-            clear_config()
+            config_manager.clear_config()
             env_vars = func_env_reload_request.environment_variables
             for var in env_vars:
                 os.environ[var] = env_vars[var]
-            read_config(
+            config_manager.read_config(
                 os.path.join(
                     func_env_reload_request.function_app_directory, "az-config.json"
                 )
@@ -835,7 +834,7 @@ async def _handle__function_environment_reload_request(self, request):
                 self._get_sync_tp_max_workers()
             )
 
-            if is_envvar_true(PYTHON_ENABLE_DEBUG_LOGGING):
+            if config_manager.is_envvar_true(PYTHON_ENABLE_DEBUG_LOGGING):
                 root_logger = logging.getLogger()
                 root_logger.setLevel(logging.DEBUG)
 
@@ -847,7 +846,7 @@ async def _handle__function_environment_reload_request(self, request):
             bindings.load_binding_registry()
 
             capabilities = {}
-            if get_app_setting(
+            if config_manager.get_app_setting(
                 setting=PYTHON_ENABLE_OPENTELEMETRY,
                 default_value=PYTHON_ENABLE_OPENTELEMETRY_DEFAULT,
             ):
@@ -856,7 +855,7 @@ async def _handle__function_environment_reload_request(self, request):
                 if self._azure_monitor_available:
                     capabilities[constants.WORKER_OPEN_TELEMETRY_ENABLED] = _TRUE
 
-            if is_envvar_true(PYTHON_ENABLE_INIT_INDEXING):
+            if config_manager.is_envvar_true(PYTHON_ENABLE_INIT_INDEXING):
                 try:
                     self.load_function_metadata(
                         directory, caller_info="environment_reload_request"
@@ -1057,7 +1056,7 @@ def tp_max_workers_validator(value: str) -> bool:
             else f"{PYTHON_THREADPOOL_THREAD_COUNT_DEFAULT}"
         )
 
-        max_workers = get_app_setting(
+        max_workers = config_manager.get_app_setting(
             setting=PYTHON_THREADPOOL_THREAD_COUNT,
             default_value=default_value,
             validator=tp_max_workers_validator,

azure_functions_worker/http_v2.py

@@ -14,7 +14,7 @@
     X_MS_INVOCATION_ID,
 )
 from azure_functions_worker.logging import logger
-from azure_functions_worker.utils.config_manager import is_envvar_false
+from azure_functions_worker.utils.config_manager import config_manager
 
 
 # Http V2 Exceptions
@@ -280,7 +280,7 @@ def ext_base(cls):
     @classmethod
     def _check_http_v2_enabled(cls):
         if sys.version_info.minor < BASE_EXT_SUPPORTED_PY_MINOR_VERSION or \
-                is_envvar_false(PYTHON_ENABLE_INIT_INDEXING):
+                config_manager.is_envvar_false(PYTHON_ENABLE_INIT_INDEXING):
             return False
 
         import azurefunctions.extensions.base as ext_base

azure_functions_worker/loader.py

@@ -26,7 +26,7 @@
     RETRY_POLICY,
 )
 from .logging import logger
-from .utils.config_manager import get_app_setting
+from .utils.config_manager import config_manager
 from .utils.wrappers import attach_message_to_exception
 
 _AZURE_NAMESPACE = '__app__'
@@ -255,7 +255,7 @@ def index_function_app(function_path: str):
                     f"level function app instances are defined.")
 
     if not app:
-        script_file_name = get_app_setting(
+        script_file_name = config_manager.get_app_setting(
             setting=PYTHON_SCRIPT_FILE_NAME,
             default_value=f'{PYTHON_SCRIPT_FILE_NAME_DEFAULT}')
         raise ValueError("Could not find top level function app instances in "

azure_functions_worker/utils/app_setting_manager.py

@@ -2,7 +2,7 @@
 # Licensed under the MIT License.
 import sys
 
-from .config_manager import get_config
+from .config_manager import config_manager
 from ..constants import (
     FUNCTIONS_WORKER_SHARED_MEMORY_DATA_TRANSFER_ENABLED,
     PYTHON_ENABLE_DEBUG_LOGGING,
@@ -19,7 +19,7 @@
 
 
 def get_python_appsetting_state():
-    current_vars = get_config()
+    current_vars = config_manager.get_config()
     python_specific_settings = [
         PYTHON_ROLLBACK_CWD_PATH,
         PYTHON_THREADPOOL_THREAD_COUNT,

azure_functions_worker/utils/common.py

@@ -4,7 +4,7 @@
 import re
 import sys
 from types import ModuleType
-import azure_functions_worker.utils.config_manager as config_manager
+from azure_functions_worker.utils.config_manager import config_manager
 
 from azure_functions_worker.constants import (
     CUSTOMER_PACKAGES_PATH,