Skip to content

Commit b2e2a60

Browse files
committed
feedback
1 parent df51f33 commit b2e2a60

7 files changed

+63
-18
lines changed

eng/ci/docker-tests.yml renamed to eng/ci/docker-consumption-tests.yml

+1-11
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
1-
trigger:
2-
batch: true
3-
branches:
4-
include:
5-
- dev
6-
- release/*
7-
81
# CI only, does not trigger on PRs.
92
pr: none
103

@@ -42,7 +35,4 @@ extends:
4235
stages:
4336
- stage: RunDockerConsumptionTests
4437
jobs:
45-
- template: /eng/templates/official/jobs/ci-consumption-tests.yml@self
46-
- stage: RunDockerDedicatedTests
47-
jobs:
48-
- template: /eng/templates/official/jobs/ci-dedicated-tests.yml@self
38+
- template: /eng/templates/official/jobs/ci-docker-consumption-tests.yml@self

eng/ci/docker-dedicated-tests.yml

+38
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# CI only, does not trigger on PRs.
2+
pr: none
3+
4+
schedules:
5+
- cron: "0 11 * * *"
6+
displayName: Run everyday at 6 AM CST
7+
branches:
8+
include:
9+
- dev
10+
always: true
11+
12+
resources:
13+
repositories:
14+
- repository: 1es
15+
type: git
16+
name: 1ESPipelineTemplates/1ESPipelineTemplates
17+
ref: refs/tags/release
18+
- repository: eng
19+
type: git
20+
name: engineering
21+
ref: refs/tags/release
22+
23+
variables:
24+
- template: ci/variables/build.yml@eng
25+
- template: /ci/variables/cfs.yml@eng
26+
27+
extends:
28+
template: v1/1ES.Unofficial.PipelineTemplate.yml@1es
29+
parameters:
30+
pool:
31+
name: 1es-pool-azfunc
32+
image: 1es-windows-2022
33+
os: windows
34+
35+
stages:
36+
- stage: RunDockerDedicatedTests
37+
jobs:
38+
- template: /eng/templates/official/jobs/ci-docker-dedicated-tests.yml@self

eng/ci/official-build.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ extends:
5555
- stage: RunDockerConsumptionTests
5656
dependsOn: Build
5757
jobs:
58-
- template: /eng/templates/official/jobs/ci-consumption-tests.yml@self
58+
- template: /eng/templates/official/jobs/ci-docker-consumption-tests.yml@self
5959
- stage: RunDockerDedicatedTests
6060
dependsOn: Build
6161
jobs:
62-
- template: /eng/templates/official/jobs/ci-dedicated-tests.yml@self
62+
- template: /eng/templates/official/jobs/ci-docker-dedicated-tests.yml@self
6363
- stage: RunLinuxConsumptionTests
6464
dependsOn: Build
6565
jobs:

eng/templates/official/jobs/build-artifacts.yml

+20
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
jobs:
22
- job: Build_WINDOWS_X64
3+
pool:
4+
name: 1es-pool-azfunc-public
5+
image: 1es-windows-2022
6+
os: windows
37
strategy:
48
matrix:
59
Python37V4:
@@ -31,6 +35,10 @@ jobs:
3135
architecture: 'x64'
3236
artifactName: '$(pythonVersion)_WINDOWS_X64'
3337
- job: Build_WINDOWS_X86
38+
pool:
39+
name: 1es-pool-azfunc-public
40+
image: 1es-windows-2022
41+
os: windows
3442
strategy:
3543
matrix:
3644
Python37V4:
@@ -62,6 +70,10 @@ jobs:
6270
architecture: 'x86'
6371
artifactName: '$(pythonVersion)_WINDOWS_x86'
6472
- job: Build_LINUX_X64
73+
pool:
74+
name: 1es-pool-azfunc
75+
image: 1es-ubuntu-22.04
76+
os: linux
6577
strategy:
6678
matrix:
6779
Python37V4:
@@ -92,6 +104,10 @@ jobs:
92104
workerPath: '$(workerPath)'
93105
artifactName: '$(pythonVersion)_LINUX_X64'
94106
- job: Build_OSX_X64
107+
pool:
108+
name: Azure Pipelines
109+
image: macOS-latest
110+
os: macOS
95111
strategy:
96112
matrix:
97113
Python37V4:
@@ -122,6 +138,10 @@ jobs:
122138
workerPath: '$(workerPath)'
123139
artifactName: '$(pythonVersion)_OSX_X64'
124140
- job: Build_OSX_ARM64
141+
pool:
142+
name: Azure Pipelines
143+
image: macOS-latest
144+
os: macOS
125145
strategy:
126146
matrix:
127147
Python39V4:

tests/utils/testutils_docker.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,8 @@ def create_container(self, image_repo: str, image_url: str,
132132
)
133133

134134
function_path = "/home/site/wwwroot"
135-
136-
if configs.libraries:
137-
configs.libraries.append('azurefunctions-extensions-base')
138-
else:
139-
configs.libraries = ['azurefunctions-extensions-base']
135+
configs.libraries = ((configs.libraries or [])
136+
+ ['azurefunctions-extensions-base'])
140137
install_libraries_cmd = []
141138
install_libraries_cmd.extend(['pip', 'install'])
142139
install_libraries_cmd.extend(['--platform=manylinux2014_x86_64'])

0 commit comments

Comments
 (0)