Skip to content

Commit af10930

Browse files
committed
renamed registries as constants
1 parent a0920c1 commit af10930

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

azure_functions_worker/bindings/meta.py

+18-18
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
# Base extension supported Python minor version
1919
BASE_EXT_SUPPORTED_PY_MINOR_VERSION = 8
2020

21-
binding_registry = None
22-
deferred_binding_registry = None
21+
BINDING_REGISTRY = None
22+
DEFERRED_BINDING_REGISTRY = None
2323
deferred_bindings_enabled = False
2424
deferred_bindings_cache = {}
2525

@@ -31,13 +31,13 @@ def load_binding_registry() -> None:
3131
if func is None:
3232
import azure.functions as func
3333

34-
global binding_registry
35-
binding_registry = func.get_binding_registry()
34+
global BINDING_REGISTRY
35+
BINDING_REGISTRY = func.get_binding_registry()
3636

37-
if binding_registry is None:
38-
# If the binding_registry is None, azure-functions hasn't been
37+
if BINDING_REGISTRY is None:
38+
# If the BINDING_REGISTRY is None, azure-functions hasn't been
3939
# loaded in properly.
40-
raise AttributeError('binding_registry is None. Sys Path:'
40+
raise AttributeError('BINDING_REGISTRY is None. Sys Path:'
4141
f'{sys.path}, Sys Module: {sys.modules},'
4242
f'python-packages Path exists:'
4343
f'{os.path.exists(CUSTOMER_PACKAGES_PATH)}')
@@ -47,8 +47,8 @@ def load_binding_registry() -> None:
4747
# Import the base extension
4848
try:
4949
import azure.functions.extension.base as clients
50-
global deferred_binding_registry
51-
deferred_binding_registry = clients.get_binding_registry()
50+
global DEFERRED_BINDING_REGISTRY
51+
DEFERRED_BINDING_REGISTRY = clients.get_binding_registry()
5252
except ImportError:
5353
# This means that the customer hasn't imported the library.
5454
# This isn't an error.
@@ -58,9 +58,9 @@ def load_binding_registry() -> None:
5858
def get_deferred_binding(bind_name: str,
5959
pytype: typing.Optional[type] = None) -> object:
6060
# This will return None if not a supported type
61-
return deferred_binding_registry.get(bind_name)\
62-
if (deferred_binding_registry is not None
63-
and deferred_binding_registry.check_supported_type(
61+
return DEFERRED_BINDING_REGISTRY.get(bind_name)\
62+
if (DEFERRED_BINDING_REGISTRY is not None
63+
and DEFERRED_BINDING_REGISTRY.check_supported_type(
6464
pytype)) else None
6565

6666

@@ -69,7 +69,7 @@ def get_binding(bind_name: str, pytype: typing.Optional[type] = None) -> object:
6969
binding = get_deferred_binding(bind_name=bind_name, pytype=pytype)
7070
# Binding is not a deferred binding type
7171
if binding is None:
72-
binding = binding_registry.get(bind_name)
72+
binding = BINDING_REGISTRY.get(bind_name)
7373
# Binding is generic
7474
if binding is None:
7575
binding = generic.GenericBinding
@@ -134,8 +134,8 @@ def from_incoming_proto(
134134

135135
try:
136136
# if the binding is an sdk type binding
137-
if (deferred_binding_registry is not None
138-
and deferred_binding_registry.check_supported_type(pytype)):
137+
if (DEFERRED_BINDING_REGISTRY is not None
138+
and DEFERRED_BINDING_REGISTRY.check_supported_type(pytype)):
139139
return deferred_bindings_decode(binding=binding,
140140
pb=pb,
141141
pytype=pytype,
@@ -261,10 +261,10 @@ def deferred_bindings_decode(binding: typing.Any,
261261

262262
def set_deferred_bindings_flag(param_anno: type):
263263
# If flag hasn't already been set
264-
# If deferred_binding_registry is not None
264+
# If DEFERRED_BINDING_REGISTRY is not None
265265
# If the binding type is a deferred binding type
266266
global deferred_bindings_enabled
267267
if (not deferred_bindings_enabled
268-
and deferred_binding_registry is not None
269-
and deferred_binding_registry.check_supported_type(param_anno)):
268+
and DEFERRED_BINDING_REGISTRY is not None
269+
and DEFERRED_BINDING_REGISTRY.check_supported_type(param_anno)):
270270
deferred_bindings_enabled = True

azure_functions_worker/loader.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,11 @@ def get_fx_raw_bindings(indexed_function, function_info):
248248
# If the flag is True, we know that:
249249
# 1. Library is imported
250250
# 2. At least one binding is a defined deferred binding type
251-
# 3. deferred_binding_registry is not None
251+
# 3. DEFERRED_BINDING_REGISTRY is not None
252252
if bindings.meta.deferred_bindings_enabled:
253253
# Reset the flag
254254
bindings.meta.deferred_bindings_enabled = False
255-
return bindings.meta.deferred_binding_registry.get_raw_bindings(
255+
return bindings.meta.DEFERRED_BINDING_REGISTRY.get_raw_bindings(
256256
indexed_function, function_info.input_types)
257257

258258
else:

0 commit comments

Comments
 (0)