Addressed comments

Author: gavin-aguiar

setup.py

@@ -21,7 +21,7 @@
 from setuptools.command import develop
 
 from azure_functions_worker.version import VERSION
-from tests.utils.constants import AZURE_EXTENSIONS
+from tests.utils.constants import EXTENSIONS_CSPROJ_TEMPLATE
 
 # The GitHub repository of the Azure Functions Host
 WEBHOST_GITHUB_API = "https://api.github.com/repos/Azure/azure-functions-host"
@@ -243,7 +243,7 @@ def _install_extensions(self):
 
         if not (self.extensions_dir / "extensions.csproj").exists():
             with open(self.extensions_dir / "extensions.csproj", "w") as f:
-                print(AZURE_EXTENSIONS, file=f)
+                print(EXTENSIONS_CSPROJ_TEMPLATE, file=f)
 
         with open(self.extensions_dir / "NuGet.config", "w") as f:
             print(NUGET_CONFIG, file=f)

tests/unittests/test_script_file_name.py

@@ -31,7 +31,7 @@ def setUpClass(cls):
 
     @classmethod
     def tearDownClass(cls):
-        # Remove the WEBSITE_HOSTNAME environment variable
+        # Remove the PYTHON_SCRIPT_FILE_NAME environment variable
         os.environ.pop('PYTHON_SCRIPT_FILE_NAME')
         super().tearDownClass()
 
@@ -60,7 +60,7 @@ def setUpClass(cls):
 
     @classmethod
     def tearDownClass(cls):
-        # Remove the WEBSITE_HOSTNAME environment variable
+        # Remove the PYTHON_SCRIPT_FILE_NAME environment variable
         os.environ.pop('PYTHON_SCRIPT_FILE_NAME')
         super().tearDownClass()
 
@@ -89,7 +89,7 @@ def setUpClass(cls):
 
     @classmethod
     def tearDownClass(cls):
-        # Remove the WEBSITE_HOSTNAME environment variable
+        # Remove the PYTHON_SCRIPT_FILE_NAME environment variable
         os.environ.pop('PYTHON_SCRIPT_FILE_NAME')
         super().tearDownClass()
 

tests/utils/constants.py

@@ -3,7 +3,7 @@
 import pathlib
 
 # Extensions necessary for non-core bindings.
-AZURE_EXTENSIONS = """\
+EXTENSIONS_CSPROJ_TEMPLATE = """\
 <?xml version="1.0" encoding="UTF-8"?>
    <Project Sdk="Microsoft.NET.Sdk">
       <PropertyGroup>

tests/utils/testutils.py

@@ -48,7 +48,7 @@
 from tests.utils.constants import PYAZURE_WORKER_DIR, \
     PYAZURE_INTEGRATION_TEST, PROJECT_ROOT, WORKER_CONFIG, \
     CONSUMPTION_DOCKER_TEST, DEDICATED_DOCKER_TEST, PYAZURE_WEBHOST_DEBUG, \
-    ARCHIVE_WEBHOST_LOGS, AZURE_EXTENSIONS
+    ARCHIVE_WEBHOST_LOGS, EXTENSIONS_CSPROJ_TEMPLATE
 from tests.utils.testutils_docker import WebHostConsumption, WebHostDedicated, \
     DockerConfigs
 
@@ -199,6 +199,11 @@ def get_environment_variables(cls):
 
     @classmethod
     def docker_tests_enabled(self) -> (bool, str):
+        """
+        Returns True if the environment variables
+        CONSUMPTION_DOCKER_TEST or DEDICATED_DOCKER_TEST
+        is enabled else returns False
+        """
         if is_envvar_true(CONSUMPTION_DOCKER_TEST):
             return True, CONSUMPTION_DOCKER_TEST
         elif is_envvar_true(DEDICATED_DOCKER_TEST):
@@ -1015,7 +1020,7 @@ def _symlink_dir(src, dst):
         dst.symlink_to(src, target_is_directory=True)
 
 
-def _setup_func_app(app_root, is_unit_test):
+def _setup_func_app(app_root, is_unit_test=False):
     extensions = app_root / 'bin'
     host_json = app_root / 'host.json'
     extensions_csproj_file = app_root / 'extensions.csproj'
@@ -1026,7 +1031,7 @@ def _setup_func_app(app_root, is_unit_test):
 
     if not os.path.isfile(extensions_csproj_file) and not is_unit_test:
         with open(extensions_csproj_file, 'w') as f:
-            f.write(AZURE_EXTENSIONS)
+            f.write(EXTENSIONS_CSPROJ_TEMPLATE)
 
         _symlink_dir(EXTENSIONS_PATH, extensions)