Skip to content

Commit 5fe1a93

Browse files
committed
fix errors
1 parent a8478ee commit 5fe1a93

File tree

3 files changed

+40
-28
lines changed

3 files changed

+40
-28
lines changed

tests/endtoend/sql_functions/sql_functions_stein/function_app.py

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,12 @@
99

1010
@app.route(route="sql_input/{productid}")
1111
@app.sql_input(arg_name="products",
12-
command_text="SELECT * FROM Products WHERE ProductId = @ProductId",
13-
command_type="Text",
14-
parameters="@ProductId={productid}"
15-
connection_string_setting="AzureWebJobsSqlConnectionString")
16-
def sql_input(req: func.HttpRequest, products: func.SqlRowList) -> func.HttpResponse:
12+
command_text="SELECT * FROM Products WHERE ProductId = @ProductId",
13+
command_type="Text",
14+
parameters="@ProductId={productid}",
15+
connection_string_setting="AzureWebJobsSqlConnectionString")
16+
def sql_input(req: func.HttpRequest, products: func.SqlRowList) \
17+
-> func.HttpResponse:
1718
rows = list(map(lambda r: json.loads(r.to_json()), products))
1819

1920
return func.HttpResponse(
@@ -22,13 +23,14 @@ def sql_input(req: func.HttpRequest, products: func.SqlRowList) -> func.HttpResp
2223
mimetype="application/json"
2324
)
2425

26+
2527
@app.route(route="sql_input2/{productid}")
26-
@app.sql_input(arg_name="products",
28+
@app.sql_input2(arg_name="products",
2729
command_text="SELECT * FROM Products2 WHERE ProductId = @ProductId",
2830
command_type="Text",
29-
parameters="@ProductId={productid}"
31+
parameters="@ProductId={productid}",
3032
connection_string_setting="AzureWebJobsSqlConnectionString")
31-
def sql_input(req: func.HttpRequest, products: func.SqlRowList) -> func.HttpResponse:
33+
def sql_input2(req: func.HttpRequest, products: func.SqlRowList) -> func.HttpResponse:
3234
rows = list(map(lambda r: json.loads(r.to_json()), products))
3335

3436
return func.HttpResponse(
@@ -37,11 +39,12 @@ def sql_input(req: func.HttpRequest, products: func.SqlRowList) -> func.HttpResp
3739
mimetype="application/json"
3840
)
3941

42+
4043
@app.route()
4144
@app.sql_output(arg_name="r",
4245
command_text="[dbo].[Products]",
4346
connection_string_setting="AzureWebJobsSqlConnectionString")
44-
def sql_output(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.HttpResponse:
47+
def sql_output(req: func.HttpRequest, r: func.Out[func.SqlRow]) -> func.HttpResponse:
4548
body = json.loads(req.get_body())
4649
row = func.SqlRow.from_dict(body)
4750
r.set(row)
@@ -52,6 +55,7 @@ def sql_output(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.Ht
5255
mimetype="application/json"
5356
)
5457

58+
5559
@app.sql_trigger(arg_name="changes",
5660
table_name="Products",
5761
connection_string_setting="AzureWebJobsSqlConnectionString")
@@ -61,4 +65,4 @@ def sql_output(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.Ht
6165
def sql_trigger(changes, r: func.Out[func.SqlRow]) -> str:
6266
row = func.SqlRow.from_dict(json.loads(changes)[0]["Item"])
6367
r.set(row)
64-
return "OK"
68+
return "OK"

tests/endtoend/sql_functions/sql_functions_stein/generic/function_app.py

Lines changed: 24 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,11 @@
1010
@app.generic_trigger(arg_name="req", type="httpTrigger", route="sql_input/{productid}")
1111
@app.generic_output_binding(arg_name="$return", type="http")
1212
@app.generic_input_binding(arg_name="products", type="sql",
13-
command_text="SELECT * FROM Products WHERE ProductId = @ProductId",
14-
command_type="Text",
15-
parameters="@ProductId={productid}"
16-
connection_string_setting="AzureWebJobsSqlConnectionString")
13+
command_text="SELECT * FROM Products"
14+
"WHERE ProductId = @ProductId",
15+
command_type="Text",
16+
parameters="@ProductId={productid}",
17+
connection_string_setting="AzureWebJobsSqlConnectionString")
1718
def sql_input(req: func.HttpRequest, products: func.SqlRowList) -> func.HttpResponse:
1819
rows = list(map(lambda r: json.loads(r.to_json()), products))
1920

@@ -23,14 +24,16 @@ def sql_input(req: func.HttpRequest, products: func.SqlRowList) -> func.HttpResp
2324
mimetype="application/json"
2425
)
2526

27+
2628
@app.generic_trigger(arg_name="req", type="httpTrigger", route="sql_input2/{productid}")
2729
@app.generic_output_binding(arg_name="$return", type="http")
2830
@app.generic_input_binding(arg_name="products", type="sql",
29-
command_text="SELECT * FROM Products2 WHERE ProductId = @ProductId",
30-
command_type="Text",
31-
parameters="@ProductId={productid}"
32-
connection_string_setting="AzureWebJobsSqlConnectionString")
33-
def sql_input(req: func.HttpRequest, products: func.SqlRowList) -> func.HttpResponse:
31+
command_text="SELECT * FROM Products2 "
32+
"WHERE ProductId = @ProductId",
33+
command_type="Text",
34+
parameters="@ProductId={productid}",
35+
connection_string_setting="AzureWebJobsSqlConnectionString")
36+
def sql_input2(req: func.HttpRequest, products: func.SqlRowList) -> func.HttpResponse:
3437
rows = list(map(lambda r: json.loads(r.to_json()), products))
3538

3639
return func.HttpResponse(
@@ -39,12 +42,15 @@ def sql_input(req: func.HttpRequest, products: func.SqlRowList) -> func.HttpResp
3942
mimetype="application/json"
4043
)
4144

45+
4246
@app.generic_trigger(arg_name="req", type="httpTrigger")
4347
@app.generic_output_binding(arg_name="$return", type="http")
4448
@app.generic_output_binding(arg_name="r", type="sql",
45-
command_text="[dbo].[Products]",
46-
connection_string_setting="AzureWebJobsSqlConnectionString")
47-
def sql_output(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.HttpResponse:
49+
command_text="[dbo].[Products]",
50+
connection_string_setting="AzureWebJobs"
51+
"SqlConnectionString")
52+
def sql_output(req: func.HttpRequest, r: func.Out[func.SqlRow]) \
53+
-> func.HttpResponse:
4854
body = json.loads(req.get_body())
4955
row = func.SqlRow.from_dict(body)
5056
r.set(row)
@@ -55,13 +61,14 @@ def sql_output(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.Ht
5561
mimetype="application/json"
5662
)
5763

64+
5865
@app.generic_trigger(arg_name="changes", type="sqlTrigger",
59-
table_name="Products",
60-
connection_string_setting="AzureWebJobsSqlConnectionString")
66+
table_name="Products",
67+
connection_string_setting="AzureWebJobsSqlConnectionString")
6168
@app.generic_output_binding(arg_name="r", type="sql",
62-
command_text="[dbo].[Products2]",
63-
connection_string_setting="AzureWebJobsSqlConnectionString")
69+
command_text="[dbo].[Products2]",
70+
connection_string_setting="AzureWebJobsSqlConnectionString")
6471
def sql_trigger(changes, r: func.Out[func.SqlRow]) -> str:
6572
row = func.SqlRow.from_dict(json.loads(changes)[0]["Item"])
6673
r.set(row)
67-
return "OK"
74+
return "OK"

tests/endtoend/test_sql_functions.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ def test_sql_binding_trigger(self):
5151
else:
5252
break
5353

54+
5455
class TestSqlFunctionsStein(TestSqlFunctions):
5556

5657
@classmethod
@@ -64,4 +65,4 @@ class TestSqlFunctionsSteinGeneric(TestSqlFunctions):
6465
@classmethod
6566
def get_script_dir(cls):
6667
return testutils.E2E_TESTS_FOLDER / 'sql_functions' / \
67-
'sql_functions_stein' / 'generic'
68+
'sql_functions_stein' / 'generic'

0 commit comments

Comments
 (0)