changes

Author: lzchen

azure_functions_worker/constants.py

@@ -82,15 +82,13 @@
 BASE_EXT_SUPPORTED_PY_MINOR_VERSION = 8
 
 # Appsetting to turn on OpenTelemetry support/features
-# A value of "true" enables the setting, defaults to "false"
+# A value of "true" enables the setting
 PYTHON_ENABLE_OPENTELEMETRY = "PYTHON_ENABLE_OPENTELEMETRY"
-PYTHON_ENABLE_OPENTELEMETRY_DEFAULT = "false"
 
 # Appsetting to turn on ApplicationInsights support/features
-# A value of "true" enables the setting, defaults to "false"
+# A value of "true" enables the setting
 PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY = \
     "PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY"
-PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY_DEFAULT = "false"
 
 # Appsetting to specify root logger name of logger to collect telemetry for
 # Used by Azure monitor distro (Application Insights)

azure_functions_worker/dispatcher.py

@@ -31,9 +31,7 @@
     PYTHON_ENABLE_DEBUG_LOGGING,
     PYTHON_ENABLE_INIT_INDEXING,
     PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY,
-    PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY_DEFAULT,
     PYTHON_ENABLE_OPENTELEMETRY,
-    PYTHON_ENABLE_OPENTELEMETRY_DEFAULT,
     PYTHON_LANGUAGE_RUNTIME,
     PYTHON_ROLLBACK_CWD_PATH,
     PYTHON_SCRIPT_FILE_NAME,
@@ -386,20 +384,11 @@ async def _handle__worker_init_request(self, request):
             constants.SHARED_MEMORY_DATA_TRANSFER: _TRUE,
         }
 
-        opentelemetry_app_setting = get_app_setting(
-            setting=PYTHON_ENABLE_OPENTELEMETRY,
-            default_value=PYTHON_ENABLE_OPENTELEMETRY_DEFAULT,
-        )
-
-        appinsights_app_setting = get_app_setting(
-            setting=PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY,
-            default_value=PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY_DEFAULT,
-        )
-        if appinsights_app_setting and appinsights_app_setting.lower() == "true":
+        if is_envvar_true(PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY):
             self.initialize_azure_monitor()
 
-        if opentelemetry_app_setting and opentelemetry_app_setting.lower() == "true":
-            self._otel_libs_available = True
+        if is_envvar_true(PYTHON_ENABLE_OPENTELEMETRY):
+            self.initialize_azure_monitor()
 
         if self._azure_monitor_available or self._otel_libs_available:
             capabilities[constants.WORKER_OPEN_TELEMETRY_ENABLED] = _TRUE
@@ -795,13 +784,9 @@ async def _handle__function_environment_reload_request(self, request):
             bindings.load_binding_registry()
 
             capabilities = {}
-            if get_app_setting(
-                    setting=PYTHON_ENABLE_OPENTELEMETRY,
-                    default_value=PYTHON_ENABLE_OPENTELEMETRY_DEFAULT):
+            if is_envvar_true(PYTHON_ENABLE_OPENTELEMETRY):
                 self._otel_libs_available = True
-            if get_app_setting(
-                    setting=PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY,
-                    default_value=PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY_DEFAULT):
+            if is_envvar_true(PYTHON_APPLICATIONINSIGHTS_ENABLE_TELEMETRY):
                 self.initialize_azure_monitor()
 
             if self._azure_monitor_available or self._otel_libs_available:

pyproject.toml

@@ -45,6 +45,7 @@ Repository = "https://github.com/Azure/azure-functions-python-worker"
 dev = [
     "azure-eventhub", # Used for EventHub E2E tests
     "azure-functions-durable", # Used for Durable E2E tests
+    "azure-monitor-opentelemetry", # Used for Azure Monitor unit tests
     "flask",
     "fastapi~=0.103.2",
     "pydantic",

tests/unittests/test_opentelemetry.py

@@ -169,7 +169,7 @@ def test_init_request_enable_opentelemetry_enabled_app_setting(
         self.assertIn("WorkerOpenTelemetryEnabled", capabilities)
         self.assertEqual(capabilities["WorkerOpenTelemetryEnabled"], "true")
 
-    @patch.dict(os.environ, {})
+    @patch.dict(os.environ, {'PYTHON_ENABLE_OPENTELEMETRY': 'false'})
     def test_init_request_enable_opentelemetry_default_app_setting(
         self,
     ):