unit test fixes

Author: Victoria Hall

azure_functions_worker/utils/config_manager.py

@@ -30,7 +30,7 @@ def config_exists() -> bool:
     global config_data
     if config_data is None:
         read_config("")
-    return config_data is not {}
+    return config_data is not None
 
 
 def get_config() -> dict:
@@ -52,20 +52,22 @@ def is_false_like(setting: str) -> bool:
 
 
 def is_envvar_true(key: str) -> bool:
+    key_upper = key.upper()
     # special case for PYTHON_ENABLE_DEBUG_LOGGING
     # This is read by the host and must be set in os.environ
-    if key == "PYTHON_ENABLE_DEBUG_LOGGING":
-        val = os.getenv(key)
+    if key_upper == "PYTHON_ENABLE_DEBUG_LOGGING":
+        val = os.getenv(key_upper)
         return is_true_like(val)
-    if config_exists() and config_data.get(key) is not None:
-        return is_true_like(config_data.get(key))
-    return False
+    if config_exists() and not config_data.get(key_upper):
+        return False
+    return is_true_like(config_data.get(key_upper))
 
 
 def is_envvar_false(key: str) -> bool:
-    if config_exists() and config_data.get(key) is not None:
-        return is_false_like(config_data.get(key))
-    return False
+    key_upper = key.upper()
+    if config_exists() and not config_data.get(key_upper):
+        return False
+    return is_false_like(config_data.get(key_upper))
 
 
 def get_app_setting(
@@ -93,9 +95,10 @@ def get_app_setting(
     Optional[str]
         A string value that is set in the application setting
     """
-    if config_exists() and config_data.get(setting) is not None:
+    setting_upper = setting.upper()
+    if config_exists() and config_data.get(setting_upper) is not None:
         # Setting exists, check with validator
-        app_setting_value = config_data.get(setting)
+        app_setting_value = config_data.get(setting_upper)
 
         # If there's no validator, return the app setting value directly
         if validator is None:
@@ -120,3 +123,10 @@ def set_env_var(setting: str, value: str):
 def del_env_var(setting: str):
     global config_data
     config_data.pop(setting, None)
+
+
+def clear_config():
+    global config_data
+    if config_data is not None:
+        config_data.clear()
+        config_data = None

tests/unittests/test_dispatcher.py

@@ -23,6 +23,7 @@
     PYTHON_THREADPOOL_THREAD_COUNT_MIN,
 )
 from azure_functions_worker.dispatcher import Dispatcher, ContextEnabledTask
+from azure_functions_worker.utils import config_manager
 from azure_functions_worker.version import VERSION
 
 SysVersionInfo = col.namedtuple("VersionInfo", ["major", "minor", "micro",
@@ -62,6 +63,7 @@ def tearDown(self):
         os.environ.clear()
         os.environ.update(self._pre_env)
         self.mock_version_info.stop()
+        config_manager.clear_config()
 
     async def test_dispatcher_initialize_worker(self):
         """Test if the dispatcher can be initialized worker successfully

tests/unittests/test_shared_memory_manager.py

@@ -9,6 +9,7 @@
 from unittest.mock import patch
 
 from azure.functions import meta as bind_meta
+from azure_functions_worker.utils import config_manager
 from tests.utils import testutils
 
 from azure_functions_worker.bindings.shared_memory_data_transfer import (
@@ -31,6 +32,7 @@ class TestSharedMemoryManager(testutils.SharedMemoryTestCase):
     Tests for SharedMemoryManager.
     """
     def setUp(self):
+        config_manager.clear_config()
         env = os.environ.copy()
         env['FUNCTIONS_WORKER_SHARED_MEMORY_DATA_TRANSFER_ENABLED'] = "true"
         self.mock_environ = patch.dict('os.environ', env)

tests/unittests/test_utilities.py

@@ -87,6 +87,7 @@ def tearDown(self):
         self.mock_sys_path.stop()
         self.mock_sys_module.stop()
         self.mock_environ.stop()
+        config_manager.clear_config()
 
     def test_is_true_like_accepted(self):
         self.assertTrue(config_manager.is_true_like('1'))
@@ -113,15 +114,15 @@ def test_is_false_like_rejected(self):
         self.assertFalse(config_manager.is_false_like('secret'))
 
     def test_is_envvar_true(self):
-        config_manager.set_env_var(TEST_FEATURE_FLAG, 'true')
+        os.environ[TEST_FEATURE_FLAG] = 'true'
         self.assertTrue(config_manager.is_envvar_true(TEST_FEATURE_FLAG))
 
     def test_is_envvar_not_true_on_unset(self):
         self._unset_feature_flag()
         self.assertFalse(config_manager.is_envvar_true(TEST_FEATURE_FLAG))
 
     def test_is_envvar_false(self):
-        config_manager.set_env_var(TEST_FEATURE_FLAG, 'false')
+        os.environ[TEST_FEATURE_FLAG] = 'false'
         self.assertTrue(config_manager.is_envvar_false(TEST_FEATURE_FLAG))
 
     def test_is_envvar_not_false_on_unset(self):

tests/unittests/test_utilities_dependency.py

@@ -7,7 +7,7 @@
 from unittest.mock import patch
 
 from azure_functions_worker.utils.dependency import DependencyManager
-from azure_functions_worker.utils.config_manager import read_config
+from azure_functions_worker.utils.config_manager import clear_config
 from tests.utils import testutils
 
 
@@ -38,7 +38,7 @@ def setUp(self):
         self._patch_sys_path.start()
         self._patch_importer_cache.start()
         self._patch_modules.start()
-        read_config("")
+        clear_config()
 
     def tearDown(self):
         self._patch_environ.stop()