-
Notifications
You must be signed in to change notification settings - Fork 68
Can't import WsgiMiddleware #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @cecilphillip,
Thanks for reporting this issue. |
@Hazhzeng Thanks! I just assumed that it would use the version of the package that's specified in the So does the core tools just ignore that package and install other dependencies? I'm just trying to understand how that works. |
Yes, so far we ignore the azure-functions library in requirements.txt in local dev and host runtime, and we bound a specific version of azure-functions library in every host release. |
@Hazhzeng So how do devs consuming the library know what version of the they can depend on? |
@cecilphillip we have a schedule for rolling out new library every 2 weeks. We have a discussion with Maheer (who was the former developer on Python worker), if we bind the library version with customer's code, the customer needs to redeploy their function app when we release a new version of azure-functions library. These releases are backward compatible and include bug fixes on python worker and azure-functions library. We made a decision to roll-out these libraries with the host so the customer's app can be run on the latest version automatically without manual intervention. If you have any doubts, feel free to let me know and suggestions are welcomed. cc: @anirudhgarg Thanks, |
I think most devs would have the expectation that whatever package versions they install should be the versions that ends up in their deployment, but I also understand your reasoning. I have 2 suggestions
|
@Hazhzeng is 1.2.0 rolled out to functions-core-tools yet? |
@Hazhzeng would you mind re-opening the issue as I cannot see a way it's resolved: for a local installation I can obviously remove the azure folder in the core tools directory. But how would I do that when my function is deployed to Azure?
|
Oh sorry, I think the merge of the PR automatically closed this issue, I will reopen it again. |
I ran into this issue today. Any update on this?
I looked into the Dockerfile that was provided for Azure function. It has My current workaround is created a custom Dockerfile that manually remove it and then install the latest one with pip |
This one is already deployed on production. Closing the thread. |
@Hazhzeng Does this mean that we no longer need to base the image from |
Yes now this is included in the Consumption plan and in the images we use in the Dedicated/Premium plan and in CoreTools. |
Uh oh!
There was an error while loading. Please reload this page.
I just created a new functions project and tried to import
WsgiMiddleware
as mentioned in #45, but it won't resolve for some reason.I'm using Python 3.7.4, core tools version 3.0.2245, and v1.2.0 of the azure-functions package
Running the code above results in
@Hazhzeng am I missing something?
The text was updated successfully, but these errors were encountered: