Address

Author: Evan Roman

azurefunctions-extensions-bindings-blob/azurefunctions/extensions/bindings/blob/blobClient.py

@@ -11,7 +11,7 @@
 
 
 class BlobClient(SdkType):
-    def __init__(self, *, data: Union[bytes, Datum]) -> None:
+    def __init__(self, *, data: Datum) -> None:
         # model_binding_data properties
         self._data = data
         self._using_managed_identity = False

azurefunctions-extensions-bindings-eventhub/azurefunctions/extensions/bindings/eventhub/eventHubData.py

@@ -1,15 +1,15 @@
 #  Copyright (c) Microsoft Corporation. All rights reserved.
 #  Licensed under the MIT License.
 
-from typing import Union
+from typing import Optional, Union
 import uamqp
 
 from azure.eventhub import EventData
 from azurefunctions.extensions.base import Datum, SdkType
 
 
 class EventHubData(SdkType):
-    def __init__(self, *, data: Union[bytes, Datum]) -> None:
+    def __init__(self, *, data: Datum) -> None:
         # model_binding_data properties
         self._data = data
         self._version = None
@@ -25,14 +25,28 @@ def __init__(self, *, data: Union[bytes, Datum]) -> None:
             self.decoded_message = self.__get_eventhub_content(self._content)
 
     def __get_eventhub_content(self, content):
+        """
+        When receiving the EventBindingData, the content field is in the form of bytes.
+        This content must be decoded in order to construct an EventData object from the azure.eventhub SDK.
+        The .NET worker uses the Azure.Core.Amqp library to do this:
+        https://github.com/Azure/azure-functions-dotnet-worker/blob/main/extensions/Worker.Extensions.EventHubs/src/EventDataConverter.cs#L45
+        """
         if content:
-            return uamqp.Message().decode_from_bytes(content)
-        else:
-            return None
+            try:
+                return uamqp.Message().decode_from_bytes(content)
+            except Exception as e:
+                raise ValueError(f"Failed to decode EventHub content: {e}") from e
+            
+        return None
 
-    def get_sdk_type(self):
+    def get_sdk_type(self) -> Optional[EventData]:
+        """
+        When receiving an EventHub message, the content portion after being decoded
+        is used in the constructor to create an EventData object. This will contains
+        fields such as message, enqueue_time, and more.
+        """
         # https://github.com/Azure/azure-sdk-for-python/issues/39711
         if self.decoded_message:
             return EventData._from_message(self.decoded_message)
-        else:
-            return None
+        
+        return None

azurefunctions-extensions-bindings-eventhub/azurefunctions/extensions/bindings/eventhub/eventHubDataConverter.py

@@ -1,7 +1,7 @@
 #  Copyright (c) Microsoft Corporation. All rights reserved.
 #  Licensed under the MIT License.
 
-from typing import Any
+from typing import Any, Optional
 
 from azurefunctions.extensions.base import Datum, InConverter, OutConverter
 
@@ -21,22 +21,20 @@ def check_input_type_annotation(cls, pytype: type) -> bool:
         )
 
     @classmethod
-    def decode(cls, data: Datum, *, trigger_metadata, pytype) -> Any:
+    def decode(cls, data: Datum, *, trigger_metadata, pytype) -> Optional[Any]:
         if data is None or data.type is None:
             return None
 
-        data_type = data.type
-
-        if data_type == "model_binding_data":
-            data = data.value
-        else:
+        if data.type != "model_binding_data":
             raise ValueError(
-                f'unexpected type of data received for the "eventhub" binding '
-                f": {data_type!r}"
+                 "Unexpected type of data received for the 'eventhub' binding: "
+                + repr(data.type)
             )
+        
+        content = data.value
 
         # Determines which sdk type to return based on pytype
         if pytype == EventHubData:
-            return EventHubData(data=data).get_sdk_type()
-        else:
-            return None
+            return EventHubData(data=content).get_sdk_type()
+        
+        return None

azurefunctions-extensions-bindings-eventhub/pyproject.toml

@@ -17,6 +17,7 @@ classifiers= [
         'Programming Language :: Python :: 3.9',
         'Programming Language :: Python :: 3.10',
         'Programming Language :: Python :: 3.11',
+        'Programming Language :: Python :: 3.12',
         'Operating System :: Microsoft :: Windows',
         'Operating System :: POSIX',
         'Operating System :: MacOS :: MacOS X',