Skip to content

Commit 6bc641f

Browse files
authored
Linux node placeholders (#4835)
* Linux node placeholders * tests
1 parent 9395a7e commit 6bc641f

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/WebJobs.Script/Rpc/RpcInitializationService.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ public class RpcInitializationService : IManagedHostedService
3232
},
3333
{
3434
OSPlatform.Linux,
35-
new List<string>() { LanguageWorkerConstants.PythonLanguageWorkerName }
35+
new List<string>()
36+
{
37+
LanguageWorkerConstants.PythonLanguageWorkerName,
38+
LanguageWorkerConstants.NodeLanguageWorkerName
39+
}
3640
}
3741
};
3842

test/WebJobs.Script.Tests/Rpc/RpcInitializationServiceTests.cs

+6
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ public async Task RpcInitializationService_Initializes_RpcServerAndChannels_Wind
7272
await _rpcInitializationService.StartAsync(CancellationToken.None);
7373
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Once);
7474
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.PythonLanguageWorkerName), Times.Never);
75+
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.NodeLanguageWorkerName), Times.Never);
7576
Assert.Contains("testserver", testRpcServer.Uri.ToString());
7677
await testRpcServer.ShutdownAsync();
7778
}
@@ -88,6 +89,7 @@ public async Task RpcInitializationService_Initializes_RpcServerOnly_Windows_NoP
8889
await _rpcInitializationService.StartAsync(CancellationToken.None);
8990
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Never);
9091
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.PythonLanguageWorkerName), Times.Never);
92+
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.NodeLanguageWorkerName), Times.Never);
9193
Assert.Contains("testserver", testRpcServer.Uri.ToString());
9294
await testRpcServer.ShutdownAsync();
9395
}
@@ -104,6 +106,7 @@ public async Task RpcInitializationService_Initializes_RpcServerAndChannels_Linu
104106
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _logger);
105107
await _rpcInitializationService.StartAsync(CancellationToken.None);
106108
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.PythonLanguageWorkerName), Times.Once);
109+
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.NodeLanguageWorkerName), Times.Once);
107110
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Never);
108111
Assert.Contains("testserver", testRpcServer.Uri.ToString());
109112
await testRpcServer.ShutdownAsync();
@@ -121,6 +124,7 @@ public async Task RpcInitializationService_Initializes_RpcServerOnly_LinuxConsum
121124
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _logger);
122125
await _rpcInitializationService.StartAsync(CancellationToken.None);
123126
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.PythonLanguageWorkerName), Times.Never);
127+
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.NodeLanguageWorkerName), Times.Never);
124128
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Never);
125129
Assert.Contains("testserver", testRpcServer.Uri.ToString());
126130
await testRpcServer.ShutdownAsync();
@@ -139,6 +143,7 @@ public async Task RpcInitializationService_Initializes_RpcServerAndChannels_Linu
139143
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _logger);
140144
await _rpcInitializationService.StartAsync(CancellationToken.None);
141145
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.PythonLanguageWorkerName), Times.Once);
146+
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.NodeLanguageWorkerName), Times.Once);
142147
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Never);
143148
Assert.Contains("testserver", testRpcServer.Uri.ToString());
144149
await testRpcServer.ShutdownAsync();
@@ -157,6 +162,7 @@ public async Task RpcInitializationService_Initializes_RpcServerOnly_LinuxAppSer
157162
_rpcInitializationService = new RpcInitializationService(_optionsMonitor, mockEnvironment.Object, testRpcServer, _mockLanguageWorkerChannelManager.Object, _logger);
158163
await _rpcInitializationService.StartAsync(CancellationToken.None);
159164
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.PythonLanguageWorkerName), Times.Never);
165+
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.NodeLanguageWorkerName), Times.Never);
160166
_mockLanguageWorkerChannelManager.Verify(m => m.InitializeChannelAsync(LanguageWorkerConstants.JavaLanguageWorkerName), Times.Never);
161167
Assert.Contains("testserver", testRpcServer.Uri.ToString());
162168
await testRpcServer.ShutdownAsync();

0 commit comments

Comments
 (0)