Skip to content

Commit 1648c1c

Browse files
authored
fix recovoery requires vmss state file (#107)
1 parent 85a4137 commit 1648c1c

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

AzureBasicLoadBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/AzureBasicLoadBalancerUpgrade.psd1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
RootModule = 'AzureBasicLoadBalancerUpgrade'
1313

1414
# Version number of this module.
15-
ModuleVersion = '2.4.4'
15+
ModuleVersion = '2.4.5'
1616

1717
# Supported PSEditions
1818
# CompatiblePSEditions = @()
@@ -107,7 +107,7 @@
107107
# IconUri = ''
108108

109109
# ReleaseNotes of this module
110-
ReleaseNotes = 'Enhanced -multiLBConfig validation to prevent incorrect useage'
110+
ReleaseNotes = 'Fix VMSS state file parameter always required in recovery'
111111

112112
# Prerelease string of this module
113113
# Prerelease = ''

AzureBasicLoadBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/modules/Start-AzBasicLoadBalancerUpgrade/Start-AzBasicLoadBalancerUpgrade.psm1

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -152,15 +152,13 @@ function Start-AzBasicLoadBalancerUpgrade {
152152
[Parameter(Mandatory = $True, ParameterSetName = 'ByName')][string] $BasicLoadBalancerName,
153153
[Parameter(Mandatory = $True, ValueFromPipeline, ParameterSetName = 'ByObject')][Microsoft.Azure.Commands.Network.Models.PSLoadBalancer] $BasicLoadBalancer,
154154
[Parameter(Mandatory = $True, ParameterSetName = 'ByJsonVm')][string]
155-
[Parameter(Mandatory = $True, ParameterSetName = 'ByJsonVmss')][string]
156-
$FailedMigrationRetryFilePathLB,
157-
[Parameter(Mandatory = $True, ParameterSetName = 'ByJsonVmss')][string] $FailedMigrationRetryFilePathVMSS,
155+
[Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVmss')][string]$FailedMigrationRetryFilePathLB,
156+
[Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVmss')][string] $FailedMigrationRetryFilePathVMSS,
158157
[Parameter(Mandatory = $false, ParameterSetName = 'ValidateCompletedMigration')][string]
159158
[Parameter(Mandatory = $false, ParameterSetName = 'ByName')][string]
160159
[Parameter(Mandatory = $false, ParameterSetName = 'ByObject')][string]
161160
[Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVm')][string]
162-
[Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVmss')][string]
163-
$StandardLoadBalancerName,
161+
[Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVmss')][string] $StandardLoadBalancerName,
164162
[Parameter(Mandatory = $false)][string] $RecoveryBackupPath = $pwd,
165163
[Parameter(Mandatory = $false)][switch] $FollowLog,
166164
[Parameter(Mandatory = $false)][switch] $validateScenarioOnly,
@@ -169,8 +167,7 @@ function Start-AzBasicLoadBalancerUpgrade {
169167
[Parameter(Mandatory = $false, ParameterSetName = 'ByObject')][switch]
170168
[Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVmss')][switch]
171169
[Parameter(Mandatory = $false, ParameterSetName = 'MultiLB')][switch]
172-
[Parameter(Mandatory = $false, ParameterSetName = 'ValidateCompletedMigration')][switch]
173-
$skipUpgradeNATPoolsToNATRules,
170+
[Parameter(Mandatory = $false, ParameterSetName = 'ValidateCompletedMigration')][switch]$skipUpgradeNATPoolsToNATRules,
174171
[Parameter(Mandatory = $true, ParameterSetName = 'ValidateCompletedMigration')][switch] $validateCompletedMigration,
175172
[Parameter(Mandatory = $true, ParameterSetName = 'ValidateCompletedMigration')][string] $basicLoadBalancerStatePath,
176173
[Parameter(Mandatory = $false)][switch] $outputMigrationValiationObj,

0 commit comments

Comments
 (0)