Skip to content

Commit 6d77447

Browse files
committed
Disable the jsx-a11y/no-onchange lint rule
As outlined in jsx-eslint/eslint-plugin-jsx-a11y#398, the rule is no longer relevant. It goes against the official React docs and keyboard navigation in <select> controls works fine using the `onChange` prop. The issue was in browsers older than IE 11. The rule will be removed from jsx-a11y/recommended in a future release.
1 parent a0a0288 commit 6d77447

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.eslintrc.js

+4
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,10 @@ module.exports = {
263263
// i18n-calypso translate triggers false failures
264264
'jsx-a11y/anchor-has-content': 'off',
265265

266+
// Deprecated rule, the problems using <select> with keyboards this addressed don't appear to be an issue anymore
267+
// https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/398
268+
'jsx-a11y/no-onchange': 'off',
269+
266270
'no-restricted-imports': [
267271
2,
268272
{

0 commit comments

Comments
 (0)