Skip to content

Commit cc4a7e5

Browse files
alimcmaster1WillAyd
authored andcommitted
CLN: Parmeterize test cases (pandas-dev#25355)
1 parent 0d893d0 commit cc4a7e5

File tree

1 file changed

+17
-33
lines changed

1 file changed

+17
-33
lines changed

pandas/tests/io/test_sql.py

+17-33
Original file line numberDiff line numberDiff line change
@@ -704,45 +704,29 @@ def test_complex(self):
704704
# Complex data type should raise error
705705
pytest.raises(ValueError, df.to_sql, 'test_complex', self.conn)
706706

707-
def test_to_sql_index_label(self):
708-
temp_frame = DataFrame({'col1': range(4)})
709-
707+
@pytest.mark.parametrize("index_name,index_label,expected", [
710708
# no index name, defaults to 'index'
711-
sql.to_sql(temp_frame, 'test_index_label', self.conn)
712-
frame = sql.read_sql_query('SELECT * FROM test_index_label', self.conn)
713-
assert frame.columns[0] == 'index'
714-
709+
(None, None, "index"),
715710
# specifying index_label
716-
sql.to_sql(temp_frame, 'test_index_label', self.conn,
717-
if_exists='replace', index_label='other_label')
718-
frame = sql.read_sql_query('SELECT * FROM test_index_label', self.conn)
719-
assert frame.columns[0] == "other_label"
720-
711+
(None, "other_label", "other_label"),
721712
# using the index name
722-
temp_frame.index.name = 'index_name'
723-
sql.to_sql(temp_frame, 'test_index_label', self.conn,
724-
if_exists='replace')
725-
frame = sql.read_sql_query('SELECT * FROM test_index_label', self.conn)
726-
assert frame.columns[0] == "index_name"
727-
713+
("index_name", None, "index_name"),
728714
# has index name, but specifying index_label
729-
sql.to_sql(temp_frame, 'test_index_label', self.conn,
730-
if_exists='replace', index_label='other_label')
731-
frame = sql.read_sql_query('SELECT * FROM test_index_label', self.conn)
732-
assert frame.columns[0] == "other_label"
733-
715+
("index_name", "other_label", "other_label"),
734716
# index name is integer
735-
temp_frame.index.name = 0
736-
sql.to_sql(temp_frame, 'test_index_label', self.conn,
737-
if_exists='replace')
738-
frame = sql.read_sql_query('SELECT * FROM test_index_label', self.conn)
739-
assert frame.columns[0] == "0"
740-
741-
temp_frame.index.name = None
717+
(0, None, "0"),
718+
# index name is None but index label is integer
719+
(None, 0, "0"),
720+
])
721+
def test_to_sql_index_label(self, index_name,
722+
index_label, expected):
723+
temp_frame = DataFrame({'col1': range(4)})
724+
temp_frame.index.name = index_name
725+
query = 'SELECT * FROM test_index_label'
742726
sql.to_sql(temp_frame, 'test_index_label', self.conn,
743-
if_exists='replace', index_label=0)
744-
frame = sql.read_sql_query('SELECT * FROM test_index_label', self.conn)
745-
assert frame.columns[0] == "0"
727+
index_label=index_label)
728+
frame = sql.read_sql_query(query, self.conn)
729+
assert frame.columns[0] == expected
746730

747731
def test_to_sql_index_label_multiindex(self):
748732
temp_frame = DataFrame({'col1': range(4)},

0 commit comments

Comments
 (0)