Skip to content

Commit cf155e7

Browse files
author
James Foster
authored
Merge pull request #289 from jgfoster/report_compile_errors
Use `before(:each)` rather than `before(:all)` so we can see the compile errors in GitHub Actions.
2 parents 233f8da + fa2aca9 commit cf155e7

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Diff for: CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1111
- `--min-free-space=N` command-line argument to fail if free space is below requred value
1212

1313
### Changed
14+
- Properly report compile errors in GitHub Actions (#296)
1415
- Put build artifacts in a separate directory to reduce clutter.
1516
- Change 266 files from CRLF to LF.
1617
- Update .gitattributes so we have consistent line endings

Diff for: spec/testsomething_unittests_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
context "file #{tfn} (using #{compiler})" do
7373
around(:example) { |example| fld.in_pristine_fake_libraries_dir(example) }
7474

75-
before(:all) do
75+
before(:each) do
7676
@cpp_library = backend.install_local_library(cpp_lib_path)
7777
@exe = @cpp_library.build_for_test_with_configuration(path, [], compiler, config.gcc_config("uno"))
7878
end

0 commit comments

Comments
 (0)