Skip to content

Commit ae213dd

Browse files
committed
skip URL setting in justified cases
1 parent 490e323 commit ae213dd

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
99
- C++ functions for `assure`; `assert`s will run tests and continue, `assure`s will abort on failures
1010

1111
### Changed
12+
- `arduino_ci_remote.rb` doesn't attempt to set URLs if nothing needs to be downloaded
1213

1314
### Deprecated
1415

exe/arduino_ci_remote.rb

+4-2
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,10 @@ def assure(message, &block)
7272
# do that, set the URLs, and download the packages
7373
all_packages = all_platforms.values.map { |v| v[:package] }.uniq.reject(&:nil?)
7474
all_urls = all_packages.map { |p| config.package_url(p) }.uniq.reject(&:nil?)
75-
assure("Setting board manager URLs") do
76-
@arduino_cmd.set_pref("boardsmanager.additional.urls", all_urls.join(","))
75+
unless all_urls.empty?
76+
assure("Setting board manager URLs") do
77+
@arduino_cmd.set_pref("boardsmanager.additional.urls", all_urls.join(","))
78+
end
7779
end
7880

7981
all_packages.each do |p|

0 commit comments

Comments
 (0)