Remove flag --no-dry-run for arduino_ci >= 0.14.0

Author: hf-4145

Diff for: CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Support for `dtostrf()`
 - Added a CI workflow to lint the code base
 - Added a CI workflow to check for spelling errors
+- Remove `--dry-run` flag for `arduino_ci` version `>= 0.14.0`
 
 ### Changed
 - We now compile a shared library to be used for each test.

Diff for: lib/arduino_ci/arduino_backend.rb

@@ -163,7 +163,11 @@ def compile_sketch(path, boardname)
         @last_msg = "Can't compile Sketch at nonexistent path '#{path}'!"
         return false
       end
-      ret = run_and_capture("compile", "--fqbn", boardname, "--warnings", "all", "--dry-run", path.to_s)
+      if should_use_dry_run?
+        ret = run_and_capture("compile", "--fqbn", boardname, "--warnings", "all", "--dry-run", path.to_s)
+      else
+        ret = run_and_capture("compile", "--fqbn", boardname, "--warnings", "all", path.to_s)
+      end
       @last_msg = ret[:out]
       ret[:success]
     end
@@ -235,5 +239,14 @@ def install_local_library(path)
       Host.symlink(src_path, destination_path)
       cpp_library
     end
+
+    private
+
+    def should_use_dry_run?
+      ret = capture_json("version")
+      version = ret[:json]["VersionString"]
+      match = /(\d)\.(\d+)\.(\d+)/.match(version)
+      return match[1].to_i == 0 && match[2].to_i < 14
+    end
   end
 end

Diff for: spec/arduino_backend_spec.rb

@@ -103,5 +103,48 @@ def get_sketch(dir, file)
     it "Passes a simple INO sketch at #{sketch_path_ino}" do
       expect(backend.compile_sketch(sketch_path_ino, "arduino:avr:uno")).to be true
     end
+
+    context "--dry-run flags" do
+      before { allow(backend).to receive(:run_and_capture).and_call_original }
+
+      it "Uses --dry-run flag for arduino_cli version < 0.14.0" do
+        parsed_stdout = JSON.parse('{ "VersionString": "0.13.6" }')
+        cli_version_output = {
+          json: parsed_stdout
+        }
+        allow(backend).to receive(:capture_json).and_return cli_version_output
+
+        backend.compile_sketch(sketch_path_ino, "arduino:avr:uno")
+
+        expect(backend).to have_received(:run_and_capture).with(
+          "compile",
+          "--fqbn",
+          "arduino:avr:uno",
+          "--warnings",
+          "all",
+          "--dry-run",
+          sketch_path_ino
+        )
+      end
+
+      it "Does not use --dry-run flag for arduino_cli version >= 0.14.0" do
+        parsed_stdout = JSON.parse('{ "VersionString": "0.14.0" }')
+        cli_version_output = {
+          json: parsed_stdout
+        }
+        allow(backend).to receive(:capture_json).and_return cli_version_output
+
+        backend.compile_sketch(sketch_path_ino, "arduino:avr:uno")
+
+        expect(backend).to have_received(:run_and_capture).with(
+          "compile",
+          "--fqbn",
+          "arduino:avr:uno",
+          "--warnings",
+          "all",
+          sketch_path_ino
+        )
+      end
+    end
   end
 end