ignore things in vendor bundle

Author: ianfixes

CHANGELOG.md

@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - All test files were reporting "not ok" in TAP output.  Now they are OK iff all asserts pass.
 - Directories with a C++ extension in their name could cause problems.  Now they are ignored.
 - `CppLibrary` had trouble with symlinks. It shoudn't anymore.
+- `CppLibrary` had trouble with vendor bundles.  It might in the future, but I have a better fix ready to go if it's an issue.
 
 ### Security
 

lib/arduino_ci/cpp_library.rb

@@ -35,6 +35,20 @@ def initialize(base_dir)
       @last_msg = ""
     end
 
+    # Guess whether a file is part of the vendor bundle (indicating we should ignore it).
+    #
+    # This assumes the vendor bundle will be at `vendor/bundle` and not some other location
+    # @param path [String] The path to check
+    # @return [Array<String>] The paths of the found files
+    def vendor_bundle?(path)
+      # TODO: look for Gemfile, look for .bundle/config and get BUNDLE_PATH from there?
+      base = File.join(@base_dir, "vendor")
+      real = File.join(File.realpath(@base_dir), "vendor")
+      return true if path.start_with?(base)
+      return true if path.start_with?(real)
+      false
+    end
+
     # Get a list of all CPP source files in a directory and its subdirectories
     # @param some_dir [String] The directory in which to begin the search
     # @return [Array<String>] The paths of the found files
@@ -52,6 +66,7 @@ def cpp_files
       cpp_files_in(@base_dir).reject do |p|
         next true if File.dirname(p).include?(tests_dir)
         next true if File.dirname(p).include?(real_tests_dir)
+        next true if vendor_bundle?(p)
       end
     end
 
@@ -84,7 +99,8 @@ def test_files
     def header_dirs
       real = File.realpath(@base_dir)
       all_files = Find.find(real).reject { |path| File.directory?(path) }
-      files = all_files.select { |path| HPP_EXTENSIONS.include?(File.extname(path)) }
+      unbundled = all_files.reject { |path| vendor_bundle?(path) }
+      files = unbundled.select { |path| HPP_EXTENSIONS.include?(File.extname(path)) }
       ret = files.map { |path| File.dirname(path) }.uniq
       puts "header_dirs found #{files}\n  returning #{ret}"
       ret