fix symlink and directory problems in CppLibrary

Author: ianfixes

CHANGELOG.md

@@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 - All test files were reporting "not ok" in TAP output.  Now they are OK iff all asserts pass.
+- Directories with a C++ extension in their name could cause problems.  Now they are ignored.
+- `CppLibrary` had trouble with symlinks. It shoudn't anymore.
 
 ### Security
 

lib/arduino_ci/cpp_library.rb

@@ -40,7 +40,9 @@ def initialize(base_dir)
     # @return [Array<String>] The paths of the found files
     def cpp_files_in(some_dir)
       real = File.realpath(some_dir)
-      Find.find(real).select { |path| CPP_EXTENSIONS.include?(File.extname(path)) }
+      files = Find.find(real).reject { |path| File.directory?(path) }
+      ret = files.select { |path| CPP_EXTENSIONS.include?(File.extname(path)) }
+      ret
     end
 
     # CPP files that are part of the project library under test
@@ -80,8 +82,11 @@ def test_files
     # Find all directories in the project library that include C++ header files
     # @return [Array<String>]
     def header_dirs
-      files = Find.find(@base_dir).select { |path| HPP_EXTENSIONS.include?(File.extname(path)) }
-      files.map { |path| File.dirname(path) }.uniq
+      real = File.realpath(@base_dir)
+      all_files = Find.find(real).reject { |path| File.directory?(path) }
+      files = all_files.select { |path| HPP_EXTENSIONS.include?(File.extname(path)) }
+      ret = files.map { |path| File.dirname(path) }.uniq
+      ret
     end
 
     # wrapper for the GCC command