Skip to content

Commit 681b6fd

Browse files
fix: do not include that source error in its own Display representation
Link: https://alampy.com/2024/05/14/a-brief-of-error-chain-in-rust/ Link: rust-lang/api-guidelines#210
1 parent 4c835c3 commit 681b6fd

File tree

7 files changed

+19
-19
lines changed

7 files changed

+19
-19
lines changed

src/printer/device.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ pub struct PrinterDevice {
1919
/// Represents an error occurred while enumerating printer devices.
2020
pub enum EnumDeviceError {
2121
/// Failed to enum printer device.
22-
#[error("Failed to enum printer device: {0}")]
22+
#[error("Failed to enum printer device")]
2323
FailedToEnumPrinterDevice(#[source] windows::core::Error),
2424
}
2525

src/printer/pdfium.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ pub enum PdfiumPrinterError {
2727
#[error("Failed to open printer")]
2828
FailedToOpenPrinter,
2929
/// File I/O error.
30-
#[error("File I/O error: {0}")]
30+
#[error("File I/O error")]
3131
FileIOError(#[source] std::io::Error),
3232
/// Print ticket error.
33-
#[error("Print Ticker Error: {0}")]
33+
#[error("Print Ticker Error")]
3434
PrintTicketError(#[source] ToDevModeError),
3535
}
3636

src/printer/xps.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,19 @@ use windows::{
2020
/// Represents an error from [`XpsPrinter`].
2121
pub enum XpsPrinterError {
2222
/// Failed to create event.
23-
#[error("Failed to create event: {0}")]
23+
#[error("Failed to create event")]
2424
FailedToCreateEvent(#[source] windows::core::Error),
2525
/// Failed to create object factory.
26-
#[error("Failed to create object factory: {0}")]
26+
#[error("Failed to create object factory")]
2727
FailedToCreateObjectFactory(#[source] windows::core::Error),
2828
/// Failed to start job.
29-
#[error("Failed to start job: {0}")]
29+
#[error("Failed to start job")]
3030
FailedToStartJob(#[source] windows::core::Error),
3131
/// Failed to apply print ticket.
32-
#[error("Failed to apply print ticket: {0}")]
32+
#[error("Failed to apply print ticket")]
3333
FailedToApplyPrintTicket(#[source] windows::core::Error),
3434
/// Failed to write document.
35-
#[error("Failed to write document: {0}")]
35+
#[error("Failed to write document")]
3636
FailedToWriteDocument(#[source] windows::core::Error),
3737
/// Stream is not available.
3838
#[error("Stream is not available")]

src/ticket/builder.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,16 @@ pub struct PrintTicketBuilder {
2525
/// Represents an error occurred while building a print ticket.
2626
pub enum PrintTicketBuilderError {
2727
/// Failed to open print ticket provider.
28-
#[error("Failed to open print ticket provider: {0}")]
28+
#[error("Failed to open print ticket provider")]
2929
OpenProviderFailed(#[source] windows::core::Error),
3030
/// Stream not allocated.
3131
#[error("Stream not allocated")]
3232
StreamNotAllocated,
3333
/// Failed to merge print tickets.
34-
#[error("Failed to merge print tickets: {0}")]
34+
#[error("Failed to merge print tickets")]
3535
MergePrintTicketsFailed(String, #[source] windows::core::Error),
3636
/// Failed to decode print ticket.
37-
#[error("Failed to decode print ticket: {0}")]
37+
#[error("Failed to decode print ticket")]
3838
DecodePrintTicketFailed(#[source] windows::core::Error),
3939
}
4040

src/ticket/document/reader.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ use xml::{
1717
/// Represents an error occurred while parsing print schema.
1818
pub enum ParsePrintSchemaError {
1919
/// Invalid XML.
20-
#[error("Invalid xml: {0}")]
20+
#[error("Invalid xml")]
2121
InvalidXml(#[source] xml::reader::Error),
2222
/// Invalid print schema.
2323
#[error("Invalid print schema: (at {pos}) {reason}")]

src/ticket/print_capabilities.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,19 @@ use xml::name::OwnedName;
2727
/// Represents an error occurred while fetching print capabilities.
2828
pub enum FetchPrintCapabilitiesError {
2929
/// Failed to open print ticket provider.
30-
#[error("Failed to open print ticket provider: {0}")]
30+
#[error("Failed to open print ticket provider")]
3131
OpenProviderFailed(#[source] windows::core::Error),
3232
/// Stream not allocated.
3333
#[error("Stream not allocated")]
3434
StreamNotAllocated,
3535
/// Cannot get print capabilities.
36-
#[error("Cannot get print capabilities: {0}")]
36+
#[error("Cannot get print capabilities")]
3737
CannotGetPrintCapabilities(String, #[source] windows::core::Error),
3838
/// Failed to read stream.
39-
#[error("Failed to read stream: {0}")]
39+
#[error("Failed to read stream")]
4040
ReadStreamFailed(#[source] windows::core::Error),
4141
/// Failed to parse print capabilities.
42-
#[error("Failed to parse print capabilities: {0}")]
42+
#[error("Failed to parse print capabilities")]
4343
ParseError(#[source] ParsePrintSchemaError),
4444
}
4545

src/ticket/print_ticket.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,16 +42,16 @@ impl Default for PrintTicket {
4242
/// Represents an error occurred while converting print ticket to dev mode.
4343
pub enum ToDevModeError {
4444
/// Failed to open print ticket provider.
45-
#[error("Failed to open print ticket provider: {0}")]
45+
#[error("Failed to open print ticket provider")]
4646
OpenProviderFailed(#[source] windows::core::Error),
4747
/// Stream not allocated.
4848
#[error("Stream not allocated")]
4949
StreamNotAllocated,
5050
/// Failed to convert print ticket to dev mode.
51-
#[error("Failed to convert print ticket to dev mode: {0}")]
51+
#[error("Failed to convert print ticket to dev mode")]
5252
ConvertPrintTicketToDevModeFailed(String, #[source] windows::core::Error),
5353
/// Failed to open printer.
54-
#[error("Failed to open printer: {0}")]
54+
#[error("Failed to open printer")]
5555
FailedToOpenPrinter(#[source] windows::core::Error),
5656
/// Failed to correct dev mode via [`DocumentProperties`].
5757
///

0 commit comments

Comments
 (0)