Skip to content

Commit f3a7a21

Browse files
committed
Changes per jreback requests
1 parent 9489cb2 commit f3a7a21

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

pandas/tests/groupby/test_groupby.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -1490,18 +1490,18 @@ def test_frame_describe_multikey(self):
14901490
for name, group in groupedT:
14911491
assert_frame_equal(result[name], group.describe())
14921492

1493-
# GH #14848
14941493
def test_frame_describe_tupleindex(self):
1494+
1495+
# GH 14848 - regression from 0.19.0 to 0.19.1
14951496
df1 = DataFrame({'x': [1, 2, 3, 4, 5] * 3,
14961497
'y': [10, 20, 30, 40, 50] * 3,
14971498
'z': [100, 200, 300, 400, 500] * 3})
14981499
df1['k'] = [(0, 0, 1), (0, 1, 0), (1, 0, 0)] * 5
14991500
df2 = df1.rename(columns={'k': 'key'})
1500-
des1 = df1.groupby('k').describe()
1501-
des2 = df2.groupby('key').describe()
1502-
if len(des1) > 0:
1503-
des2.index.set_names(des1.index.names, inplace=True)
1504-
assert_frame_equal(des1, des2)
1501+
result = df1.groupby('k').describe()
1502+
expected = df2.groupby('key').describe()
1503+
expected.index.set_names(result.index.names, inplace=True)
1504+
assert_frame_equal(result, expected)
15051505

15061506
def test_frame_groupby(self):
15071507
grouped = self.tsframe.groupby(lambda x: x.weekday())

pandas/tools/merge.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -1627,10 +1627,10 @@ def __init__(self, objs, axis=0, join='outer', join_axes=None,
16271627
objs = clean_objs
16281628
name = getattr(keys, 'name', None)
16291629
# GH 14848
1630-
# Don't pass name when creating index (# GH 14252)
1631-
# So that if keys are tuples, name isn't checked
1632-
keys = Index(clean_keys)
1633-
keys.name = name
1630+
# If you already have an Index, no need
1631+
# to recreate it
1632+
if not isinstance(keys, Index):
1633+
keys = Index(clean_keys, name=name)
16341634

16351635
if len(objs) == 0:
16361636
raise ValueError('All objects passed were None')

0 commit comments

Comments
 (0)