Skip to content

Commit 3534e16

Browse files
author
OlgaMaciaszek
committed
Adjust changes to existing convention.
1 parent 8504e7e commit 3534e16

File tree

4 files changed

+14
-15
lines changed

4 files changed

+14
-15
lines changed

spring-cloud-commons/src/main/java/org/springframework/cloud/client/discovery/simple/SimpleDiscoveryClient.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ public List<String> getServices() {
4646

4747
@Override
4848
public int getOrder() {
49-
return simpleDiscoveryProperties.getOrder();
49+
return this.simpleDiscoveryProperties.getOrder();
5050
}
5151
}

spring-cloud-commons/src/main/java/org/springframework/cloud/client/discovery/simple/SimpleDiscoveryProperties.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,19 @@ public class SimpleDiscoveryProperties {
3838
private int order = Ordered.LOWEST_PRECEDENCE;
3939

4040
public Map<String, List<SimpleServiceInstance>> getInstances() {
41-
return instances;
41+
return this.instances;
4242
}
4343

4444
public void setInstances(Map<String, List<SimpleServiceInstance>> instances) {
4545
this.instances = instances;
4646
}
4747

4848
public SimpleServiceInstance getLocal() {
49-
return local;
49+
return this.local;
5050
}
5151

5252
public int getOrder() {
53-
return order;
53+
return this.order;
5454
}
5555

5656
public void setOrder(int order) {

spring-cloud-commons/src/test/java/org/springframework/cloud/client/discovery/composite/CompositeDiscoveryClientOrderTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public class CompositeDiscoveryClientOrderTest {
3232
@Test
3333
public void shouldGetOrderedDiscoveryClients() {
3434
// when:
35-
List<DiscoveryClient> discoveryClients = ((CompositeDiscoveryClient) discoveryClient)
35+
List<DiscoveryClient> discoveryClients = ((CompositeDiscoveryClient) this.discoveryClient)
3636
.getDiscoveryClients();
3737

3838
// then:
@@ -47,7 +47,7 @@ public void shouldGetOrderedDiscoveryClients() {
4747
@Test
4848
public void shouldOnlyReturnServiceInstancesForTheHighestPrecedenceDiscoveryClient() {
4949
// when:
50-
List<ServiceInstance> serviceInstances = discoveryClient
50+
List<ServiceInstance> serviceInstances = this.discoveryClient
5151
.getInstances(CUSTOM_SERVICE_ID);
5252

5353
// then:

spring-cloud-commons/src/test/java/org/springframework/cloud/client/discovery/composite/CompositeDiscoveryClientTests.java

+8-9
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ public class CompositeDiscoveryClientTests {
3535

3636
@Test
3737
public void getInstancesByServiceIdShouldDelegateCall() {
38-
assertThat(discoveryClient).isInstanceOf(CompositeDiscoveryClient.class);
38+
assertThat(this.discoveryClient).isInstanceOf(CompositeDiscoveryClient.class);
3939

40-
assertThat(discoveryClient.getInstances("service1")).hasSize(2);
40+
assertThat(this.discoveryClient.getInstances("service1")).hasSize(2);
4141

42-
ServiceInstance s1 = discoveryClient.getInstances("service1").get(0);
42+
ServiceInstance s1 = this.discoveryClient.getInstances("service1").get(0);
4343
assertThat(s1.getHost()).isEqualTo("s1-1");
4444
assertThat(s1.getPort()).isEqualTo(8080);
4545
assertThat(s1.getUri()).isEqualTo(URI.create("http://s1-1:8080"));
@@ -48,23 +48,22 @@ public void getInstancesByServiceIdShouldDelegateCall() {
4848

4949
@Test
5050
public void getServicesShouldAggregateAllServiceNames() {
51-
assertThat(discoveryClient.getServices()).containsOnlyOnce("service1", "service2",
52-
CUSTOM_SERVICE_ID);
51+
assertThat(this.discoveryClient.getServices()).containsOnlyOnce("service1", "service2", "custom");
5352
}
5453

5554
@Test
5655
public void getDescriptionShouldBeComposite() {
57-
assertThat(discoveryClient.description()).isEqualTo("Composite Discovery Client");
56+
assertThat(this.discoveryClient.description()).isEqualTo("Composite Discovery Client");
5857
}
5958

6059
@Test
6160
public void getInstancesShouldRespectOrder() {
62-
assertThat(discoveryClient.getInstances(CUSTOM_SERVICE_ID)).hasSize(1);
63-
assertThat(discoveryClient.getInstances(CUSTOM_SERVICE_ID)).hasSize(1);
61+
assertThat(this.discoveryClient.getInstances(CUSTOM_SERVICE_ID)).hasSize(1);
62+
assertThat(this.discoveryClient.getInstances(CUSTOM_SERVICE_ID)).hasSize(1);
6463
}
6564

6665
@Test
6766
public void getInstancesByUnknownServiceIdShouldReturnAnEmptyList() {
68-
assertThat(discoveryClient.getInstances("unknown")).hasSize(0);
67+
assertThat(this.discoveryClient.getInstances("unknown")).hasSize(0);
6968
}
7069
}

0 commit comments

Comments
 (0)