ENH: add check for arg kwarg conflict for the positional case

Author: AlexKirko

asv_bench/benchmarks/tslibs/timestamp.py

@@ -51,6 +51,9 @@ def time_from_pd_timestamp(self):
     def time_from_positional(self):
         Timestamp(2020, 1, 1, 0, 0, 0)
 
+    def time_from_positional_tz(self):
+        Timestamp(2020, 1, 1, 0, 0, 0, tzinfo=pytz.UTC)
+
 
 class TimestampProperties:
     params = [_tzs]

pandas/_libs/tslibs/timestamps.pyx

@@ -1584,6 +1584,19 @@ class Timestamp(_Timestamp):
 
             if kwargs:
                 # Positional or keyword arguments
+                err_msg = (
+                    "argument for function given by name ('{}') and position ({})"
+                )
+
+                datetime_components = ["year", "month", "day", "hour", "minute",
+                                       "second", "microsecond", "tzinfo"]
+                for i, key in enumerate(datetime_components):
+                    if args_len > i:
+                        if key in kwargs:
+                            raise TypeError(err_msg.format(key, i))
+                    else:
+                        break
+
                 hour = kwargs.get("hour", hour)
                 minute = kwargs.get("minute", minute)
                 second = kwargs.get("second", second)

pandas/tests/scalar/timestamp/test_constructors.py

@@ -909,3 +909,21 @@ def test_timestamp_constructor_str_invalid_kwargs():
     )
     with pytest.raises(ValueError, match=msg):
         Timestamp("2020-01-01", foo="bar")
+
+
+@pytest.mark.parametrize(
+    "kwargs,pos_offset",
+    [
+        ({"day": 1}, 2),
+        ({"hour": 1}, 3),
+    ],
+)
+def test_timestamp_constructor_positional_arg_kwarg_conflict(kwargs, pos_offset):
+    # Check that we didn't pass anything except
+    # tz, tzinfo, unit with a string
+    msg = (
+        f"argument for function given by name \\('{next(iter(kwargs.keys()))}'\\) "
+        f"and position \\({pos_offset}\\)"
+    )
+    with pytest.raises(TypeError, match=msg):
+        Timestamp(2020, 1, 1, 1, **kwargs)