fix: Internal Server Error isn't shown if httpCode is 500, closes #55 (#56)

Author: yekver

docs/guide/configuration.md

@@ -29,6 +29,7 @@ module.exports = {
       },
       // Paths
       distPath: path.resolve(__dirname, './dist'),
+      error500Html: null,
       templatePath: path.resolve(__dirname, './dist/index.html'),
       serviceWorkerPath: path.resolve(__dirname, './dist/service-worker.js'),
       // Directives fallback

lib/app.js

@@ -106,20 +106,23 @@ module.exports = (app, options) => {
         httpCode: 200,
       }
       renderer.renderToString(context, (err, html) => {
-        if (err) {
+        if (err || context.httpCode === 500) {
           console.error(`error during render url : ${req.url}`)
-          console.error(err)
 
           // Render Error Page
           let errorHtml = config.error500Html
             ? fs.readFileSync(config.error500Html, 'utf-8')
             : '500 | Internal Server Error'
 
-          if (!isProd) {
-            const errorMessage = `<pre>${err.stack}</pre>`
-            config.error500Html
-              ? errorHtml = errorHtml.replace('<!--server-error-msg-->', errorMessage)
-              : errorHtml += errorMessage
+          if (err) {
+            console.error(err)
+
+            if (!isProd) {
+              const errorMessage = `<pre>${err.stack}</pre>`
+              config.error500Html
+                ? errorHtml = errorHtml.replace('<!--server-error-msg-->', errorMessage)
+                : errorHtml += errorMessage
+            }
           }
 
           res.status(500).send(errorHtml)

lib/config.js

@@ -6,12 +6,12 @@ module.exports = {
   entry: target => `./src/entry-${target}`,
   defaultTitle: 'My app',
   favicon: './public/favicon.ico',
-  error500Html: null,
   skipRequests: req => req.originalUrl === '/graphql',
   nodeExternalsWhitelist: [/\.css$/, /\?vue&type=style/],
   extendServer: null,
   // Paths
   distPath: null,
+  error500Html: null,
   templatePath: null,
   serviceWorkerPath: null,
   directives: {},