Removed operational chaining parameter

Author: jaishirole

lib/util.js

@@ -26,7 +26,7 @@ const operationsList = ["get", "post", "put", "delete", "patch", "options", "hea
  */
 function fixServers (server, path) {
   // Server url starting with "/" tells that it is not an http(s) url
-  if (server.url?.startsWith("/")) {
+  if (server.url && server.url.startsWith("/")) {
     const inUrl = new URL(path);
     const finalUrl = inUrl.protocol + "//" + inUrl.hostname + server.url;
     server.url = finalUrl;
@@ -39,7 +39,7 @@ function fixServers (server, path) {
  * be at root, path or operation's level
  */
 function fixOasRelativeServers (schema, filePath) {
-  if (schema?.openapi && (filePath?.startsWith("http:") || filePath?.startsWith("https:"))) {
+  if (schema.openapi && (filePath && (filePath.startsWith("http:") || filePath.startsWith("https:")))) {
     /**
      * From OpenAPI v3 spec for Server object's url property: "REQUIRED. A URL to the target host.
      * This URL supports Server Variables and MAY be relative, to indicate that the host location is relative to the location where
@@ -48,7 +48,9 @@ function fixOasRelativeServers (schema, filePath) {
      * However, interpretation of the spec says that relative paths for servers should take into account the hostname that
      * serves the OpenAPI file.
      */
-    schema.servers?.map(server => fixServers(server, filePath)); // Root level servers array's fixup
+    if (schema.servers) {
+      schema.servers.map(server => fixServers(server, filePath)); // Root level servers array's fixup
+    }
 
     // Path or Operation level servers array's fixup
     Object.keys(schema.paths).forEach(path => {
@@ -60,7 +62,9 @@ function fixOasRelativeServers (schema, filePath) {
         }
         else if (operationsList.includes(opItem)) {
           // servers at operation level
-          pathItem[opItem].servers?.map(server => fixServers(server, filePath));
+          if (pathItem[opItem].servers) {
+            pathItem[opItem].servers.map(server => fixServers(server, filePath));
+          }
         }
       });
     });

test/specs/oas-relative-servers/v3-relative-servers.spec.js

@@ -54,7 +54,7 @@ describe("Servers with relative paths in OpenAPI v3 files", () => {
       let apiJson = await SwaggerParser.parse(RELATIVE_SERVERS_OAS3_URL_2);
       expect(apiJson.servers[0].url).to.equal("https://foo.my.cloud/api/v3");
       expect(apiJson.paths["/pet"].servers[0].url).to.equal("https://foo.my.cloud/api/v4");
-      expect(apiJson.paths["/pet"]?.get.servers[0].url).to.equal("https://foo.my.cloud/api/v5");
+      expect(apiJson.paths["/pet"].get.servers[0].url).to.equal("https://foo.my.cloud/api/v5");
     }
     catch (error) {
       console.error("\n\nError in relative servers at root, path and operations test case:", error);
@@ -70,7 +70,7 @@ describe("Servers with relative paths in OpenAPI v3 files", () => {
       let apiJson = await SwaggerParser.parse(path.rel("./v3-relative-server.json"));
       expect(apiJson.servers[0].url).to.equal("/api/v3");
       expect(apiJson.paths["/pet"].servers[0].url).to.equal("/api/v4");
-      expect(apiJson.paths["/pet"]?.get.servers[0].url).to.equal("/api/v5");
+      expect(apiJson.paths["/pet"].get.servers[0].url).to.equal("/api/v5");
     }
     catch (error) {
       console.error("\n\nError in relative servers at root but local file import test case:", error);
@@ -86,7 +86,7 @@ describe("Servers with relative paths in OpenAPI v3 files", () => {
       let apiJson = await SwaggerParser.parse(path.rel("./v3-non-relative-server.json"));
       expect(apiJson.servers[0].url).to.equal("https://petstore3.swagger.com/api/v3");
       expect(apiJson.paths["/pet"].servers[0].url).to.equal("https://petstore3.swagger.com/api/v4");
-      expect(apiJson.paths["/pet"]?.get.servers[0].url).to.equal("https://petstore3.swagger.com/api/v5");
+      expect(apiJson.paths["/pet"].get.servers[0].url).to.equal("https://petstore3.swagger.com/api/v5");
     }
     catch (error) {
       console.error("\n\nError in non-relative servers at root but local file import test case:", error);