fix(ono): remove dependency on ono

BREAKING CHANGE: going to make this a breaking change in case there are people depending on the stack traces / benefits of ono

Author: jonluca

lib/dereference.ts

@@ -1,6 +1,5 @@
 import $Ref from "./ref.js";
 import Pointer from "./pointer.js";
-import { ono } from "@jsdevtools/ono";
 import * as url from "./util/url.js";
 import type $Refs from "./refs.js";
 import type { DereferenceOptions, ParserOptions } from "./options.js";
@@ -355,7 +354,8 @@ function foundCircularReference(keyPath: any, $refs: any, options: any) {
   options?.dereference?.onCircular?.(keyPath);
 
   if (!options.dereference.circular) {
-    throw ono.reference(`Circular $ref pointer found at ${keyPath}`);
+    const error = new ReferenceError(`Circular $ref pointer found at ${keyPath}`);
+    throw error;
   }
   return true;
 }

lib/index.ts

@@ -16,7 +16,6 @@ import {
   isHandledError,
   JSONParserErrorGroup,
 } from "./util/errors.js";
-import { ono } from "@jsdevtools/ono";
 import maybe from "./util/maybe.js";
 import type { ParserOptions } from "./options.js";
 import { getJsonSchemaRefParserDefaultOptions } from "./options.js";
@@ -77,7 +76,7 @@ export class $RefParser<S extends object = JSONSchema, O extends ParserOptions<S
     let promise;
 
     if (!args.path && !args.schema) {
-      const err = ono(`Expected a file path, URL, or object. Got ${args.path || args.schema}`);
+      const err = new Error(`Expected a file path, URL, or object. Got ${args.path || args.schema}`);
       return maybe(args.callback, Promise.reject(err));
     }
 
@@ -129,7 +128,7 @@ export class $RefParser<S extends object = JSONSchema, O extends ParserOptions<S
         this.schema = null; // it's already set to null at line 79, but let's set it again for the sake of readability
         return maybe(args.callback, Promise.resolve(this.schema!));
       } else {
-        throw ono.syntax(`"${this.$refs._root$Ref.path || result}" is not a valid JSON Schema`);
+        throw new SyntaxError(`"${this.$refs._root$Ref.path || result}" is not a valid JSON Schema`);
       }
     } catch (err) {
       if (!args.options.continueOnError || !isHandledError(err)) {

lib/parse.ts

@@ -1,4 +1,3 @@
-import { ono } from "@jsdevtools/ono";
 import * as url from "./util/url.js";
 import * as plugins from "./util/plugins.js";
 import {
@@ -92,7 +91,7 @@ async function readFile<S extends object = JSONSchema, O extends ParserOptions<S
       throw new UnmatchedResolverError(file.url);
     } else if (!err || !("error" in err)) {
       // Throw a generic, friendly error.
-      throw ono.syntax(`Unable to resolve $ref pointer "${file.url}"`);
+      throw new SyntaxError(`Unable to resolve $ref pointer "${file.url}"`);
     }
     // Throw the original error, if it's one of our own (user-friendly) errors.
     else if (err.error instanceof ResolverError) {
@@ -133,7 +132,7 @@ async function parseFile<S extends object = JSONSchema, O extends ParserOptions<
   try {
     const parser = await plugins.run<S, O>(parsers, "parse", file, $refs);
     if (!parser.plugin.allowEmpty && isEmpty(parser.result)) {
-      throw ono.syntax(`Error parsing "${file.url}" as ${parser.plugin.name}. \nParsed value is empty`);
+      throw new SyntaxError(`Error parsing "${file.url}" as ${parser.plugin.name}. \nParsed value is empty`);
     } else {
       return parser;
     }
@@ -144,7 +143,7 @@ async function parseFile<S extends object = JSONSchema, O extends ParserOptions<
     } else if (err && err.message && err.message.startsWith("Error parsing")) {
       throw err;
     } else if (!err || !("error" in err)) {
-      throw ono.syntax(`Unable to parse ${file.url}`);
+      throw new SyntaxError(`Unable to parse ${file.url}`);
     } else if (err.error instanceof ParserError) {
       throw err.error;
     } else {

lib/refs.ts

@@ -1,4 +1,3 @@
-import { ono } from "@jsdevtools/ono";
 import $Ref from "./ref.js";
 import * as url from "./util/url.js";
 import type { JSONSchema4Type, JSONSchema6Type, JSONSchema7Type } from "json-schema";
@@ -100,7 +99,7 @@ export default class $Refs<S extends object = JSONSchema, O extends ParserOption
     const $ref = this._$refs[withoutHash];
 
     if (!$ref) {
-      throw ono(`Error resolving $ref pointer "${path}". \n"${withoutHash}" not found.`);
+      throw new Error(`Error resolving $ref pointer "${path}". \n"${withoutHash}" not found.`);
     }
 
     $ref.set(absPath, value);
@@ -150,7 +149,7 @@ export default class $Refs<S extends object = JSONSchema, O extends ParserOption
     const $ref = this._$refs[withoutHash];
 
     if (!$ref) {
-      throw ono(`Error resolving $ref pointer "${path}". \n"${withoutHash}" not found.`);
+      throw new Error(`Error resolving $ref pointer "${path}". \n"${withoutHash}" not found.`);
     }
 
     return $ref.resolve(absPath, options, path, pathFromRoot);

lib/resolvers/file.ts

@@ -1,5 +1,4 @@
 import fs from "fs";
-import { ono } from "@jsdevtools/ono";
 import * as url from "../util/url.js";
 import { ResolverError } from "../util/errors.js";
 import type { JSONSchema, ResolverOptions } from "../types/index.js";
@@ -28,12 +27,16 @@ export default {
     try {
       path = url.toFileSystemPath(file.url);
     } catch (err: any) {
-      throw new ResolverError(ono.uri(err, `Malformed URI: ${file.url}`), file.url);
+      const e = err as Error;
+      e.message = `Malformed URI: ${file.url}: ${e.message}`;
+      throw new ResolverError(e, file.url);
     }
     try {
       return await fs.promises.readFile(path);
     } catch (err: any) {
-      throw new ResolverError(ono(err, `Error opening file "${path}"`), path);
+      const e = err as Error;
+      e.message = `Error opening file ${path}: ${e.message}`;
+      throw new ResolverError(e, path);
     }
   },
 } as ResolverOptions<JSONSchema>;

lib/resolvers/http.ts

@@ -1,4 +1,3 @@
-import { ono } from "@jsdevtools/ono";
 import * as url from "../util/url.js";
 import { ResolverError } from "../util/errors.js";
 import type { FileInfo, HTTPResolverOptions, JSONSchema } from "../types/index.js";
@@ -78,17 +77,20 @@ async function download<S extends object = JSONSchema>(
   try {
     const res = await get(u, httpOptions);
     if (res.status >= 400) {
-      throw ono({ status: res.status }, `HTTP ERROR ${res.status}`);
+      const error = new Error(`HTTP ERROR ${res.status}`) as Error & { status?: number };
+      error.status = res.status;
+      throw error;
     } else if (res.status >= 300) {
       if (!Number.isNaN(httpOptions.redirects) && redirects.length > httpOptions.redirects!) {
-        throw new ResolverError(
-          ono(
-            { status: res.status },
-            `Error downloading ${redirects[0]}. \nToo many redirects: \n  ${redirects.join(" \n  ")}`,
-          ),
-        );
+        const error = new Error(
+          `Error downloading ${redirects[0]}. \nToo many redirects: \n  ${redirects.join(" \n  ")}`,
+        ) as Error & { status?: number };
+        error.status = res.status;
+        throw new ResolverError(error);
       } else if (!("location" in res.headers) || !res.headers.location) {
-        throw ono({ status: res.status }, `HTTP ${res.status} redirect with no location header`);
+        const error = new Error(`HTTP ${res.status} redirect with no location header`) as Error & { status?: number };
+        error.status = res.status;
+        throw error;
       } else {
         const redirectTo = url.resolve(u.href, res.headers.location as string);
         return download(redirectTo, httpOptions, redirects);
@@ -101,7 +103,9 @@ async function download<S extends object = JSONSchema>(
       return Buffer.alloc(0);
     }
   } catch (err: any) {
-    throw new ResolverError(ono(err, `Error downloading ${u.href}`), u.href);
+    const e = err as Error;
+    e.message = `Error downloading ${u.href}: ${e.message}`;
+    throw new ResolverError(e, u.href);
   }
 }
 

lib/util/errors.ts

@@ -1,4 +1,3 @@
-import { Ono } from "@jsdevtools/ono";
 import { getHash, stripHash, toFileSystemPath } from "./url.js";
 import type $RefParser from "../index.js";
 import type { ParserOptions } from "../index.js";
@@ -14,7 +13,57 @@ export type JSONParserErrorType =
   | "EUNMATCHEDRESOLVER"
   | "EMISSINGPOINTER"
   | "EINVALIDPOINTER";
+const nonJsonTypes = ["function", "symbol", "undefined"];
+const protectedProps = ["constructor", "prototype", "__proto__"];
+const objectPrototype = Object.getPrototypeOf({});
+
+/**
+ * Custom JSON serializer for Error objects.
+ * Returns all built-in error properties, as well as extended properties.
+ */
+export function toJSON<T extends Error>(this: T): Error & T {
+  // HACK: We have to cast the objects to `any` so we can use symbol indexers.
+  // see https://github.com/Microsoft/TypeScript/issues/1863
+  const pojo: any = {};
+  const error = this as any;
+
+  for (const key of getDeepKeys(error)) {
+    if (typeof key === "string") {
+      const value = error[key];
+      const type = typeof value;
+
+      if (!nonJsonTypes.includes(type)) {
+        pojo[key] = value;
+      }
+    }
+  }
+
+  return pojo as Error & T;
+}
+
+/**
+ * Returns own, inherited, enumerable, non-enumerable, string, and symbol keys of `obj`.
+ * Does NOT return members of the base Object prototype, or the specified omitted keys.
+ */
+export function getDeepKeys(obj: object, omit: Array<string | symbol> = []): Set<string | symbol> {
+  let keys: Array<string | symbol> = [];
+
+  // Crawl the prototype chain, finding all the string and symbol keys
+  while (obj && obj !== objectPrototype) {
+    keys = keys.concat(Object.getOwnPropertyNames(obj), Object.getOwnPropertySymbols(obj));
+    obj = Object.getPrototypeOf(obj) as object;
+  }
 
+  // De-duplicate the list of keys
+  const uniqueKeys = new Set(keys);
+
+  // Remove any omitted keys
+  for (const key of omit.concat(protectedProps)) {
+    uniqueKeys.delete(key);
+  }
+
+  return uniqueKeys;
+}
 export class JSONParserError extends Error {
   public readonly name: string;
   public readonly message: string;
@@ -29,10 +78,10 @@ export class JSONParserError extends Error {
     this.message = message;
     this.source = source;
     this.path = null;
-
-    Ono.extend(this);
   }
 
+  toJSON = toJSON.bind(this);
+
   get footprint() {
     return `${this.path}+${this.source}+${this.code}+${this.message}`;
   }
@@ -52,9 +101,8 @@ export class JSONParserErrorGroup<
     this.message = `${this.errors.length} error${
       this.errors.length > 1 ? "s" : ""
     } occurred while reading '${toFileSystemPath(parser.$refs._root$Ref!.path)}'`;
-
-    Ono.extend(this);
   }
+  toJSON = toJSON.bind(this);
 
   static getParserErrors<S extends object = JSONSchema, O extends ParserOptions<S> = ParserOptions<S>>(
     parser: $RefParser<S, O>,

package.json

@@ -92,7 +92,6 @@
     "vitest": "^3.2.1"
   },
   "dependencies": {
-    "@jsdevtools/ono": "^7.1.3",
     "@types/json-schema": "^7.0.15",
     "js-yaml": "^4.1.0"
   },

yarn.lock

@@ -21,7 +21,6 @@ __metadata:
   dependencies:
     "@eslint/compat": "npm:^1.2.9"
     "@eslint/js": "npm:^9.28.0"
-    "@jsdevtools/ono": "npm:^7.1.3"
     "@types/eslint": "npm:^9.6.1"
     "@types/js-yaml": "npm:^4.0.9"
     "@types/json-schema": "npm:^7.0.15"
@@ -532,13 +531,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@jsdevtools/ono@npm:^7.1.3":
-  version: 7.1.3
-  resolution: "@jsdevtools/ono@npm:7.1.3"
-  checksum: 10c0/a9f7e3e8e3bc315a34959934a5e2f874c423cf4eae64377d3fc9de0400ed9f36cb5fd5ebce3300d2e8f4085f557c4a8b591427a583729a87841fda46e6c216b9
-  languageName: node
-  linkType: hard
-
 "@nodelib/fs.scandir@npm:2.1.5":
   version: 2.1.5
   resolution: "@nodelib/fs.scandir@npm:2.1.5"