Skip to content

Commit 853d2e0

Browse files
nathanchancegregkh
authored andcommitted
kbuild: Move -Wenum-enum-conversion to W=2
commit 8f6629c upstream. -Wenum-enum-conversion was strengthened in clang-19 to warn for C, which caused the kernel to move it to W=1 in commit 75b5ab1 ("kbuild: Move -Wenum-{compare-conditional,enum-conversion} into W=1") because there were numerous instances that would break builds with -Werror. Unfortunately, this is not a full solution, as more and more developers, subsystems, and distributors are building with W=1 as well, so they continue to see the numerous instances of this warning. Since the move to W=1, there have not been many new instances that have appeared through various build reports and the ones that have appeared seem to be following similar existing patterns, suggesting that most instances of this warning will not be real issues. The only alternatives for silencing this warning are adding casts (which is generally seen as an ugly practice) or refactoring the enums to macro defines or a unified enum (which may be undesirable because of type safety in other parts of the code). Move the warning to W=2, where warnings that occur frequently but may be relevant should reside. Cc: [email protected] Fixes: 75b5ab1 ("kbuild: Move -Wenum-{compare-conditional,enum-conversion} into W=1") Link: https://lore.kernel.org/[email protected]/ Signed-off-by: Nathan Chancellor <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Signed-off-by: Linus Torvalds <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 39366ad commit 853d2e0

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Diff for: scripts/Makefile.extrawarn

+4-1
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ KBUILD_CFLAGS += $(call cc-disable-warning, pointer-to-enum-cast)
130130
KBUILD_CFLAGS += -Wno-tautological-constant-out-of-range-compare
131131
KBUILD_CFLAGS += $(call cc-disable-warning, unaligned-access)
132132
KBUILD_CFLAGS += -Wno-enum-compare-conditional
133-
KBUILD_CFLAGS += -Wno-enum-enum-conversion
134133
endif
135134

136135
endif
@@ -154,6 +153,10 @@ KBUILD_CFLAGS += -Wno-missing-field-initializers
154153
KBUILD_CFLAGS += -Wno-type-limits
155154
KBUILD_CFLAGS += -Wno-shift-negative-value
156155

156+
ifdef CONFIG_CC_IS_CLANG
157+
KBUILD_CFLAGS += -Wno-enum-enum-conversion
158+
endif
159+
157160
ifdef CONFIG_CC_IS_GCC
158161
KBUILD_CFLAGS += -Wno-maybe-uninitialized
159162
endif

0 commit comments

Comments
 (0)