Skip to content

Commit 45e7d78

Browse files
author
Uwe Kleine-König
committed
samples: qmi: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Link: https://lore.kernel.org/r/d30beb557e0e97ea194028f62d3c4c10841d3e7c.1709886922.git.u.kleine-koenig@pengutronix.de Signed-off-by: Uwe Kleine-König <[email protected]>
1 parent 4998f38 commit 45e7d78

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

samples/qmi/qmi_sample_client.c

+2-4
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ static int qmi_sample_probe(struct platform_device *pdev)
511511
return ret;
512512
}
513513

514-
static int qmi_sample_remove(struct platform_device *pdev)
514+
static void qmi_sample_remove(struct platform_device *pdev)
515515
{
516516
struct qmi_sample *sample = platform_get_drvdata(pdev);
517517

@@ -520,13 +520,11 @@ static int qmi_sample_remove(struct platform_device *pdev)
520520
debugfs_remove(sample->de_dir);
521521

522522
qmi_handle_release(&sample->qmi);
523-
524-
return 0;
525523
}
526524

527525
static struct platform_driver qmi_sample_driver = {
528526
.probe = qmi_sample_probe,
529-
.remove = qmi_sample_remove,
527+
.remove_new = qmi_sample_remove,
530528
.driver = {
531529
.name = "qmi_sample_client",
532530
},

0 commit comments

Comments
 (0)