Skip to content

Commit 30ab2b0

Browse files
author
Jonas Bonn
committed
asm-generic: adapt delay.h to common implementation
Several architectures are using a common delay.h implementation that appears to have originated with the x86 architecture. This common implementation is a bit fuller than the current asm-generic version and has some compile-time checks that should be interesting for all architectures. This patch takes the common delay.h version and replaces the rather trivial asm-generic version with it. As no architecture was actually using asm-generic/delay.h, this change is rather innocuous; it will, however, allow us to switch at least four architectures over to using the asm-generic version. Signed-off-by: Jonas Bonn <[email protected]> Acked-by: Arnd Bergmann <[email protected]>
1 parent b0af8df commit 30ab2b0

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

include/asm-generic/delay.h

+15-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,23 @@
11
#ifndef __ASM_GENERIC_DELAY_H
22
#define __ASM_GENERIC_DELAY_H
33

4+
/* Undefined functions to get compile-time errors */
5+
extern void __bad_udelay(void);
6+
extern void __bad_ndelay(void);
7+
48
extern void __udelay(unsigned long usecs);
9+
extern void __ndelay(unsigned long nsecs);
10+
extern void __const_udelay(unsigned long xloops);
511
extern void __delay(unsigned long loops);
612

7-
#define udelay(n) __udelay(n)
13+
/* 0x10c7 is 2**32 / 1000000 (rounded up) */
14+
#define udelay(n) (__builtin_constant_p(n) ? \
15+
((n) > 20000 ? __bad_udelay() : __const_udelay((n) * 0x10c7ul)) : \
16+
__udelay(n))
17+
18+
/* 0x5 is 2**32 / 1000000000 (rounded up) */
19+
#define ndelay(n) (__builtin_constant_p(n) ? \
20+
((n) > 20000 ? __bad_ndelay() : __const_udelay((n) * 5ul)) : \
21+
__ndelay(n))
822

923
#endif /* __ASM_GENERIC_DELAY_H */

0 commit comments

Comments
 (0)