Feedback for V2

[256dpi]

@gibix @sandeepmistry and all others.

I want to collect some ideas and thoughts about a possible V2 of this library. Do you have anything to add to what is already tagged with the v2 milestone?

[sandeepmistry]

@256dpi the list looks good so far!

I think it's partially covered by #39, however the Wire and new I2S Arduino libraries have a function to called onReceive to set a function handler for received data (https://www.arduino.cc/en/Reference/WireOnReceive). It would be nice to have this, instead of forcing sketched to define void messageReceived(...).

[256dpi]

@sandeepmistry That's a nice idea, will create a separate issue for that.

[256dpi]

How do you feel about supporting QoS1 and QoS2? I still have the feeling it complicates things too much and might not be really used by the community.

[sandeepmistry]

Do you have any benchmarks for the RAM and code space it adds?

[256dpi]

Here are the numbers for the WiFi101 example on a MKR1000 board (without testing the code):

QoS0: 25768 bytes (9%)
QoS1: 26240 bytes (10%) + 472 bytes
QoS2: 26552 bytes (10%) + 312 bytes

Honestly, I tought the difference would be much bigger.

[sandeepmistry]

Nice! Do you nice time to check the Uno as well? It should also print out the RAM used.

[256dpi]

Here is the Arduino Uno with WiFi101:

QoS0: 25294 bytes (78%) - 1042 bytes (50%)
QoS1: 25980 bytes (80%) - 1042 bytes (50%) + 686 bytes
QoS2: 26540 bytes (82%) - 1092 bytes (53%) + 560 bytes

The differences seem to be slightly bigger.

[sandeepmistry]

Ok, not bad!

Are 1042 and 1092 bytes for the RAM? If so, it sounds reasonable to go ahead with the feature :)

[256dpi]

This is beeing addressed in #59.